Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional integration with the other Flysystem bundles #53

Open
kbond opened this issue Aug 19, 2022 · 2 comments
Open

Optional integration with the other Flysystem bundles #53

kbond opened this issue Aug 19, 2022 · 2 comments

Comments

@kbond
Copy link
Member

kbond commented Aug 19, 2022

This bundle can be configured with adapter services:

zenstruck_filesystem:
    filesystems:
        public: '@=flysystem.adapter.service'

I'll have to see if the above bundles expose the underlying adapters as services. If not, I'm not sure how this would work.

@kbond kbond mentioned this issue Aug 19, 2022
@Lustmored
Copy link
Contributor

Regarding integration with league/flysystem-bundle - it provides services for each adapter (not operator), see:

https://github.com/thephpleague/flysystem-bundle/blob/77a3dfb0fb23cb89b2b59cde6a22bc98bf13e128/src/DependencyInjection/FlysystemExtension.php#L63-L70

So we probably only need to document that or add config option that takes storageName and uses 'flysystem.adapter.'.$storageName as adapter service.

In oneup/flysystem-bundle I can see there is some manipulation around oneup_flysystem.%s_adapter service, but I have no experience with that bundle. But it looks promising 👍

@kbond
Copy link
Member Author

kbond commented Aug 21, 2022

Ok cool that will work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants