Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharable link should be in format https://zenuml.com/s-q/share/xxx #605

Closed
MrCoder opened this issue Nov 9, 2023 · 5 comments
Closed

Sharable link should be in format https://zenuml.com/s-q/share/xxx #605

MrCoder opened this issue Nov 9, 2023 · 5 comments
Assignees

Comments

@MrCoder
Copy link
Contributor

MrCoder commented Nov 9, 2023

The current format of the sharable link is https://sequence-diagram.zenuml.com/share/xxx. It should be converted to https://zenuml.com/sequence-diagram/share/xxx.

@MrCoder
Copy link
Contributor Author

MrCoder commented Nov 9, 2023

I think this should be done ONLY at the client side, leaving LaraSite behave its own way. The main reason is that it is easier to change and maintain. We could potentially change LaraSite, but that force the site to be coupled with the real domain that it is mapped to.

FAQ:

  1. Shall we also change the domain that we POST to get the link? No. The site will soon (Milestone 2) be merged to LaraSite. At that time it will be POSTing to the same domain.

@whimet
Copy link
Collaborator

whimet commented Nov 9, 2023

#606

@MrCoder
Copy link
Contributor Author

MrCoder commented Nov 9, 2023

The updated URL does not work with OG images. @unimu-cic

@unimu-cic
Copy link
Collaborator

The updated URL does not work with OG images. @unimu-cic

In which environment

@MrCoder
Copy link
Contributor Author

MrCoder commented Nov 9, 2023

The updated URL does not work with OG images. @unimu-cic

In which environment

FireWeb Staging + LaraSite Production:
Screenshot 2023-11-10 at 8 40 10 am

@MrCoder MrCoder closed this as completed Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants