Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rfc utf8 #2376

Merged
merged 2 commits into from
Aug 17, 2022
Merged

Rfc utf8 #2376

merged 2 commits into from
Aug 17, 2022

Conversation

andypost
Copy link
Contributor

@andypost andypost commented Aug 8, 2022 •
edited
Loading

Hello!

In raising this pull request, I confirm the following:

  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I updated the CHANGELOG

Small description of change:

PHP 8.2 is deprecated utf8_decode() and utf8_encode so usage needs replacement

related links:

@sonarcloud
Copy link

sonarcloud bot commented Aug 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Aug 9, 2022 •
edited
Loading

Codecov Report

Merging #2376 (86ce471) into development (79dc763) will not change coverage.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             development   #2376   +/-   ##
=============================================
  Coverage           7.14%   7.14%           
  Complexity          8627    8627           
=============================================
  Files                343     343           
  Lines              21919   21919           
=============================================
  Hits                1567    1567           
  Misses             20352   20352

@Jeckerson
Copy link
Member

Thank you!

@Jeckerson Jeckerson merged commit bd34fc9 into zephir-lang:development Aug 17, 2022
@andypost andypost deleted the rfc-utf8 branch September 2, 2022 16:24
@Jeckerson Jeckerson linked an issue Sep 19, 2022 that may be closed by this pull request
PHP 8.2 support #2370
Closed
@Jeckerson Jeckerson added the nfr New Feature Request label Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees
No one assigned
Labels
nfr New Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP 8.2 support
2 participants
@andypost @Jeckerson