-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infinite recursion #655
Comments
Looks like a good catch. For the record can you please share the west version and some basic reproduction steps? |
west version is v1.0.0 reproduction steps: west init -m https://github.com/zephyrproject-rtos/example-application reproduction
cd reproduction/
west update
west example-west-command --help # so far so good
cat > patch.diff << EOF
--- a/example-application/scripts/example_west_command.py
+++ b/example-application/scripts/example_west_command.py
@@ -24,6 +24,7 @@ reflowed for you. You can also pass
formatter_class=argparse.RawDescriptionHelpFormatter when calling
parser_adder.add_parser() below if you want to keep your line
endings.''')
+ self.manifest # Try to access manifest
def do_add_parser(self, parser_adder):
# This is a bit of boilerplate, which allows you full control over the
EOF
patch -p1 < patch.diff
west example-west-command --help # this will fail |
Hmm, I believe we fixed this in 354b0e8. @botbotty the steps to reproduce you've posted are using
Reading this property from the constructor is an attempt to read it before do_run() was called, so an error is not unexpected. Can you make this happen in another way? |
Please reopen with more details if so, thanks! |
west/src/west/commands.py
Lines 280 to 289 in 51ad886
self.die()
checks configcolor.ui
, which will callself._get_config()
again, butself._config
is stillNone
.The text was updated successfully, but these errors were encountered: