Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web instructions: quotes are wrong in build chain for Windows #10882

Closed
jimschm opened this issue Oct 26, 2018 · 0 comments
Closed

Web instructions: quotes are wrong in build chain for Windows #10882

jimschm opened this issue Oct 26, 2018 · 0 comments
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug

Comments

@jimschm
Copy link

jimschm commented Oct 26, 2018

Minor thing but an annoyance. Instructions say things like:

# Windows in cmd.exe
set ZEPHYR_TOOLCHAIN_VARIANT=gnuarmemb
set GNUARMEMB_TOOLCHAIN_PATH="C:\gnu_arm_embedded"

It turns out the double quotes on the toolchain path don't work with CMake. It will say something like:

CMake Error at D:/Git/repo/vf/zephyr/cmake/toolchain/gnuarmemb.cmake:14 (message):
  Nothing found at GNUARMEMB_TOOLCHAIN_PATH:
  '"e:/toolchains/gnu_arm_embedded"'

Since there probably is something in that path, it takes a bit of inspection to realize the double quotes from the instructions have made it all the way into the CMake script and cause the error.

There are probably multiple instances of this issue, spread across different toolchain instructions.

@carlescufi carlescufi self-assigned this Oct 26, 2018
@carlescufi carlescufi added area: Debugging bug The issue is a bug, or the PR is fixing a bug and removed area: Debugging labels Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Development

No branches or pull requests

2 participants