Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Duplicate scan, no longer available #18202

Closed
Iotfabula opened this issue Aug 12, 2019 · 3 comments
Closed

Disable Duplicate scan, no longer available #18202

Iotfabula opened this issue Aug 12, 2019 · 3 comments
Assignees
Labels
area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@Iotfabula
Copy link

Unable to disable duplicate scan filter, before latest commit ( Whitelist feature ), filter
could be disabled by declaring scan with BT_HCI_LE_SCAN_FILTER_DUP_DISABLE parameter, now
semantic changed, and this option no longer available

File affected:
include/bluetooth/bluetooth.h

Expected behavior
User should be enable disable duplicate filter, those enable to see every single BLE advertisements

Impact
New Whitelist feature, somehow make this filter always on, preventing our board to see
all adv packets

Add any other context about the problem here.

@Iotfabula Iotfabula added the bug The issue is a bug, or the PR is fixing a bug label Aug 12, 2019
@aescolar
Copy link
Member

CC @jhedberg

@ioannisg ioannisg added the priority: low Low impact/importance bug label Aug 13, 2019
@joerchan
Copy link
Contributor

The option is still there. If no filtering on scan is needed assign filter_dup to 0

struct bt_le_scan_params *scan_param =
			  BT_LE_SCAN_PARAM(BT_HCI_LE_SCAN_ACTIVE, \
					   0, \
					   BT_GAP_SCAN_FAST_INTERVAL, \
					   BT_GAP_SCAN_FAST_WINDOW

BTMON:

< HCI Command: LE Set Scan Enable (0x08|0x000c) plen 2                               #45 [hci0] 9.180057
        Scanning: Enabled (0x01)
        Filter duplicates: Disabled (0x00)

@joerchan
Copy link
Contributor

Since BT_HCI_LE_SCAN_FILTER_DUP_DISABLE = 0x00 this option can still be used as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Development

No branches or pull requests

4 participants