Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required upgrade of HAL #21202

Closed
pfl opened this issue Dec 5, 2019 · 5 comments
Closed

Required upgrade of HAL #21202

pfl opened this issue Dec 5, 2019 · 5 comments
Assignees
Labels
Enhancement Changes/Updates/Additions to existing features platform: nRF Nordic nRFx

Comments

@pfl
Copy link
Collaborator

pfl commented Dec 5, 2019

After upgrading, something like the following starts to happen suddenly:

In file included from /home/pflykt/projects/zephyrproject/modules/hal/nordic/nrfx/mdk/nrf.h:124,
                 from /home/pflykt/projects/zephyrproject/modules/hal/nordic/nrfx/drivers/nrfx_common.h:39,
                 from /home/pflykt/projects/zephyrproject/modules/hal/nordic/nrfx/nrfx.h:36,
                 from ../../../soc/arm/nordic_nrf/nrf52/soc.h:16,
                 from /home/pflykt/projects/zephyrproject/zephyr/drivers/clock_control/nrf_power_clock.c:8:
/home/pflykt/projects/zephyrproject/zephyr/drivers/clock_control/nrf_power_clock.c: In function 'clock_event_check_and_clean':
/home/pflykt/projects/zephyrproject/modules/hal/nordic/nrfx/mdk/nrf52840.h:2826:37: error: incompatible type for argument 1 of 'nrf_clock_event_check'
 #define NRF_CLOCK                   ((NRF_CLOCK_Type*)         NRF_CLOCK_BASE)
                                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/pflykt/projects/zephyrproject/zephyr/drivers/clock_control/nrf_power_clock.c:53:35: note: in expansion of macro 'NRF_CLOCK'
  bool ret = nrf_clock_event_check(NRF_CLOCK, evt) &&

After a bit of investigation, the above and other weird compile errors mean that the board HAL needs to be updated.

A much better usability solution would be to detect the HAL version in use and print out a warning that the installed and expected HAL versions differ.

@carlescufi
Copy link
Member

@pfl just checking, have you run west update?

@carlescufi carlescufi added the Enhancement Changes/Updates/Additions to existing features label Dec 5, 2019
@carlescufi
Copy link
Member

@pfl I assume you have run west update and that this issue covers the fact of handling this in a nicer way.

@jukkar
Copy link
Member

jukkar commented Dec 5, 2019

I think the idea was that west/cmake could check that modules are according to what manifest says and possibly give some information to the user if there is a mismatch so that user would know that he needs to run "west update".

@pfl
Copy link
Collaborator Author

pfl commented Dec 9, 2019

@pfl I assume you have run west update and that this issue covers the fact of handling this in a nicer way.

Yes, I did run west update as a result. So this is about either documenting such a situation, or, as @jukkar commented, have west/cmake notice that the HAL is too old wrt to the code being compiled. The latter approach would be preferred.

@carlescufi
Copy link
Member

Since this issue only covers HAL repos but the problem is in fact more general and already described here: https://github.com/zephyrproject-rtos/west/issues/333 I will close this issue in benefit of the one linked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Changes/Updates/Additions to existing features platform: nRF Nordic nRFx
Projects
None yet
Development

No branches or pull requests

5 participants