Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: updatehub: Corrupted updated when receiving CoAP duplicate packages #25704

Closed
otavio opened this issue May 28, 2020 · 2 comments · Fixed by #25683, #26093 or #25603
Closed

lib: updatehub: Corrupted updated when receiving CoAP duplicate packages #25704

otavio opened this issue May 28, 2020 · 2 comments · Fixed by #25683, #26093 or #25603
Assignees
@nandojve
Labels
area: Networking bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Milestone
v2.4.0

Comments

@otavio
Copy link
Contributor

otavio commented May 28, 2020

The updatehub library is not properly handling the case where the CoAP packages are duplicated and we end flashing a broken firmware on the device's storage.

The short term solution is to have an engine that handles these packages reception and ensures we handle the proper sequence of blocks.
@otavio otavio added the bug The issue is a bug, or the PR is fixing a bug label May 28, 2020
@hwilmers
Copy link
Contributor

There is a mechanism to avoid duplicate packages proposed in PR #25558

@nandojve nandojve self-assigned this May 28, 2020
@nandojve nandojve linked a pull request May 28, 2020 that will close this issue
lib: adding support for modem to updatehub library #25558
Closed
@carlescufi carlescufi changed the title lib: updatehub: Corrupted updated when receiving CoAP duplicate packages lib: updatehub: Corrupted updated when receiving CoAP duplicate packets Jun 2, 2020
@carlescufi carlescufi changed the title lib: updatehub: Corrupted updated when receiving CoAP duplicate packets lib: updatehub: Corrupted updated when receiving CoAP duplicate packages Jun 2, 2020
@carlescufi carlescufi added the priority: low Low impact/importance bug label Jun 2, 2020
This was linked to pull requests Jun 24, 2020
lib: coap: Add coap_get_option_int public method #25683
Merged
lib: updatehub: Add download block check #26093
Merged
lib: updatehub: Fix bus fault #25603
Merged
@nandojve nandojve added this to the v2.4.0 milestone Jun 24, 2020
@nandojve
Copy link
Member

This was addressed on #25603, #25683 and #26093.

@nandojve nandojve mentioned this issue Aug 2, 2020
Merged
This was referenced Aug 30, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nandojve nandojve

Labels
area: Networking bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Milestone
v2.4.0
4 participants
@otavio @nandojve @carlescufi @hwilmers