Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FCB support for non-0xFF flash erase values #28693

Closed
de-nordic opened this issue Sep 25, 2020 · 7 comments · Fixed by #28839
Closed

FCB support for non-0xFF flash erase values #28693

de-nordic opened this issue Sep 25, 2020 · 7 comments · Fixed by #28839
Assignees
Labels
area: Storage Storage subsystem Enhancement Changes/Updates/Additions to existing features priority: low Low impact/importance bug

Comments

@de-nordic
Copy link
Collaborator

Is your enhancement proposal related to a problem? Please describe.
Currently FCB is able to work with flash devices that erase to 0xFF values.
Since it's implementation new devices have appeared that use non-0xFF erase values (0x00), which is not supported
by the FCB as it relies on 0xFF as an erased/empty value in some cases.

Describe the solution you'd like
Make FCB flash erase value independent.

Describe alternatives you've considered
There is none as long as FCB is to be used.

Additional context
The flash API now supports flash_get_parameters that returns flash_parameters structure that has erase_value member, which is initialized by driver with the erase value.

@de-nordic de-nordic added the Enhancement Changes/Updates/Additions to existing features label Sep 25, 2020
@de-nordic de-nordic added the priority: low Low impact/importance bug label Sep 25, 2020
@nvlsianpu
Copy link
Collaborator

Also newly proposed flash_area_ersed_val() might be usefull.

@nvlsianpu nvlsianpu added the area: Storage Storage subsystem label Sep 25, 2020
@utzig
Copy link
Member

utzig commented Sep 25, 2020

Also we should consider importing fcb2 from Mynewt, it was huge improvement over fcb.

@de-nordic
Copy link
Collaborator Author

Also we should consider importing fcb2 from Mynewt, it was huge improvement over fcb.

Does the fcb2 support the original fcb or this is parallel?

@utzig
Copy link
Member

utzig commented Sep 25, 2020

Also we should consider importing fcb2 from Mynewt, it was huge improvement over fcb.

Does the fcb2 support the original fcb or this is parallel?

fcb2 originated from refactoring fcb but it ended up with a slightly different metadata formats AFAIR, so not compatible, you have to use one or the other from the beginning.

@de-nordic
Copy link
Collaborator Author

fcb2 originated from refactoring fcb but it ended up with a slightly different metadata formats AFAIR, so not compatible, you have to use one or the other from the beginning.

OK then, we will have to add it as an alternative. Do you want me to create enhancement request for importing fcb2 or do you want to post the request yourself?

@utzig
Copy link
Member

utzig commented Sep 25, 2020

fcb2 originated from refactoring fcb but it ended up with a slightly different metadata formats AFAIR, so not compatible, you have to use one or the other from the beginning.

OK then, we will have to add it as an alternative. Do you want me to create enhancement request for importing fcb2 or do you want to post the request yourself?

Please go ahead and do it! :-)

@nvlsianpu
Copy link
Collaborator

^^ Please count benefits of having fcb2 in compassion to FCB and NVS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Storage Storage subsystem Enhancement Changes/Updates/Additions to existing features priority: low Low impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants