Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose net_ipv4_create, net_ipv6_create, and net_udp_create in standard header #33646

Closed
galak opened this issue Mar 23, 2021 · 4 comments
Closed
Assignees
Labels
area: Networking Enhancement Changes/Updates/Additions to existing features

Comments

@galak
Copy link
Collaborator

galak commented Mar 23, 2021

Currently some of the modem drivers (drivers/modem/hl7800.c and drivers/modem/wncm14a2a.c) are calling net_ipv6_create, net_ipv4_create and net_udp_create which requires having:

zephyr_library_include_directories(${ZEPHYR_BASE}/subsys/net/ip) in CMakeLists.txt. If these are suppose to be APIs that can be called on the networking subystem we should look to move them into include/net/ somewhere.

@galak galak added the Enhancement Changes/Updates/Additions to existing features label Mar 23, 2021
@galak
Copy link
Collaborator Author

galak commented Mar 23, 2021

@jukkar was looking at various places we do zephyr_library_include_directories and if there is some implied cleanup that needs to happen. This is one area related to networking interfaces and modem. Don't really know much about it beyond that.

@jukkar
Copy link
Member

jukkar commented Mar 24, 2021

I would like not to expose these APIs by putting them to include/net, as they are meant for internal use. Is there some issue if zephyr_library_include_directories is used in the driver?
Calling these private APIs from drivers is ok, but I would like to avoid exposing them to applications.

@galak
Copy link
Collaborator Author

galak commented Mar 24, 2021

I would like not to expose these APIs by putting them to include/net, as they are meant for internal use. Is there some issue if zephyr_library_include_directories is used in the driver?
Calling these private APIs from drivers is ok, but I would like to avoid exposing them to applications.

There's not a specific issue, just trying to ensure some level of encapsulation - even if its between a subsystem a driver.

@galak
Copy link
Collaborator Author

galak commented Mar 24, 2021

@jukkar will close this out, we need a general solution/agreement on how subsystems export APIs to other parts of zephyr (not application).

@galak galak closed this as completed Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Networking Enhancement Changes/Updates/Additions to existing features
Projects
None yet
Development

No branches or pull requests

2 participants