You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently some of the modem drivers (drivers/modem/hl7800.c and drivers/modem/wncm14a2a.c) are calling net_ipv6_create, net_ipv4_create and net_udp_create which requires having:
zephyr_library_include_directories(${ZEPHYR_BASE}/subsys/net/ip) in CMakeLists.txt. If these are suppose to be APIs that can be called on the networking subystem we should look to move them into include/net/ somewhere.
The text was updated successfully, but these errors were encountered:
@jukkar was looking at various places we do zephyr_library_include_directories and if there is some implied cleanup that needs to happen. This is one area related to networking interfaces and modem. Don't really know much about it beyond that.
I would like not to expose these APIs by putting them to include/net, as they are meant for internal use. Is there some issue if zephyr_library_include_directories is used in the driver?
Calling these private APIs from drivers is ok, but I would like to avoid exposing them to applications.
I would like not to expose these APIs by putting them to include/net, as they are meant for internal use. Is there some issue if zephyr_library_include_directories is used in the driver?
Calling these private APIs from drivers is ok, but I would like to avoid exposing them to applications.
There's not a specific issue, just trying to ensure some level of encapsulation - even if its between a subsystem a driver.
Currently some of the modem drivers (drivers/modem/hl7800.c and drivers/modem/wncm14a2a.c) are calling
net_ipv6_create
,net_ipv4_create
andnet_udp_create
which requires having:zephyr_library_include_directories(${ZEPHYR_BASE}/subsys/net/ip)
inCMakeLists.txt
. If these are suppose to be APIs that can be called on the networking subystem we should look to move them intoinclude/net/
somewhere.The text was updated successfully, but these errors were encountered: