Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing response parameter for HCI_LE_Set_Connectionless_IQ_Sampling_Enable HCI command #35781

Closed
ppryga-nordic opened this issue May 28, 2021 · 0 comments · Fixed by #35788
Closed
Assignees
Labels
area: Bluetooth Controller area: Bluetooth Host bug The issue is a bug, or the PR is fixing a bug

Comments

@ppryga-nordic
Copy link
Collaborator

Describe the bug
Response HCI_Command_Complete event generated by BLE controller on HCI_LE_Set_Connectionless_IQ_Sampling_Enable command has missing return parameter: sync_handle

To Reproduce
Two nRF52833 DKs are required.
First one must run direction_finding_connectionless_tx sample.
Second one must run direction_finding_connectionless_rx sample.

Error may not be observed when BLE controller runs with Zephyrs host.
It may be observer if controller is working with host that expect correct sync_handle return parameter.
In such situation every call to enable CTE receive and sampling in controller should fail due to:

  • expected different length of response event,
  • wrong sync_handle parameter value.

Expected behavior
Controller should include sync_handle parameter in returned HCI_Command_Complete event.
Host implementation should fail with -EIO if the sync_handle parameter is invalid.

Impact
It may impact all BLE host implementations that expect and verify correct return parameters in HCI_Command_Complete for HCI_LE_Set_Connectionless_IQ_Sampling_Enable.
It does not affect Zephyrs host implementation because the parameter was not verified there.

Logs and console output

Environment (please complete the following information):

  • Current main branch: e.g commit: 94e8c2e.

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Bluetooth Controller area: Bluetooth Host bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants