Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISO broadcast cannot send with callback if CONFIG_BT_CONN=n #38563

Closed
Thalley opened this issue Sep 15, 2021 · 3 comments · Fixed by #38614
Closed

ISO broadcast cannot send with callback if CONFIG_BT_CONN=n #38563

Thalley opened this issue Sep 15, 2021 · 3 comments · Fixed by #38614
Assignees
Labels
area: Bluetooth ISO Bluetooth LE Isochronous Channels area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@Thalley
Copy link
Collaborator

Thalley commented Sep 15, 2021

Describe the bug
#38194 introduced a bug for ISO broadcast if CONFIG_BT_CONN=n.
If CONFIG_BT_CONN=n then the free_tx FIFO is never intiialized, causes the FIFO to be empty and thus no able to use the bt_conn_send_cb function that bt_iso_chan_send now relies on.

Update: It seems that TX still works, but the callback is missing.

To Reproduce
Steps to reproduce the behavior:
Build and run samples/bluetooth/iso_broadcast/ and see the <err> bt_conn.bt_conn_send_cb: Unable to allocate TX context error

Expected behavior
Expect broadcast ISO to be fully independent on CONFIG_BT_CONN.

Impact
Showstopper for specific builds. Increased memory usage as a work around.

Logs and console output
N/A

Environment (please complete the following information):

  • Commit SHA or Version used: cd5357c

Additional context
Add any other context about the problem here.

@Thalley Thalley added the bug The issue is a bug, or the PR is fixing a bug label Sep 15, 2021
@Thalley Thalley self-assigned this Sep 15, 2021
@Thalley Thalley added area: Bluetooth area: Bluetooth ISO Bluetooth LE Isochronous Channels priority: medium Medium impact/importance bug labels Sep 15, 2021
@carlescufi
Copy link
Member

@Thalley will you send a fix in time for 2.7.0?

@Thalley
Copy link
Collaborator Author

Thalley commented Sep 16, 2021

@Thalley will you send a fix in time for 2.7.0?

That's the plan :)

@Thalley Thalley changed the title ISO broadcast cannot send if CONFIG_BT_CONN=n ISO broadcast cannot send with callback if CONFIG_BT_CONN=n Sep 16, 2021
@Thalley Thalley added priority: low Low impact/importance bug and removed priority: medium Medium impact/importance bug labels Sep 16, 2021
@Thalley
Copy link
Collaborator Author

Thalley commented Sep 16, 2021

Updated the priority to low as the callback is just missing, but it is still sending data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Bluetooth ISO Bluetooth LE Isochronous Channels area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants