Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgmt/mcumg/lib: Encode shell command execution result in additional field of response #40893

Closed
de-nordic opened this issue Dec 3, 2021 · 0 comments · Fixed by #49399
Closed
Assignees
Labels
area: mcumgr Enhancement Changes/Updates/Additions to existing features
Projects

Comments

@de-nordic
Copy link
Collaborator

Is your enhancement proposal related to a problem? Please describe.
Currently a code returned from execution of shell command is encoded as "rc" in response for a request; normally the "rc" field is used to encode error from mcumgr, so it may be sometimes not possible to distinguish between intended non-0 code from shell and mcumgr error.

Describe the solution you'd like
"rc" of the mcumgr/smp response should be only used to carry mcumgr errors; return code from shell should be given dedicated field in response.

Describe alternatives you've considered
Leaving as is.

@de-nordic de-nordic added the Enhancement Changes/Updates/Additions to existing features label Dec 3, 2021
@de-nordic de-nordic added this to To do in mcumgr via automation Dec 3, 2021
@nordicjm nordicjm moved this from To do to In progress in mcumgr Aug 23, 2022
@nordicjm nordicjm self-assigned this Aug 23, 2022
mcumgr automation moved this from In progress to Done in release 3.2 Sep 1, 2022
@nordicjm nordicjm moved this from Done in release 3.2 to Done in mcumgr Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: mcumgr Enhancement Changes/Updates/Additions to existing features
Projects
Development

Successfully merging a pull request may close this issue.

2 participants