Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bt_gatt_write_without_response_cb doesn't use callback #45549

Closed
PavelVPV opened this issue May 11, 2022 · 2 comments · Fixed by #45680
Closed

bt_gatt_write_without_response_cb doesn't use callback #45549

PavelVPV opened this issue May 11, 2022 · 2 comments · Fixed by #45680
Labels
area: Bluetooth Host bug The issue is a bug, or the PR is fixing a bug

Comments

@PavelVPV
Copy link
Collaborator

PavelVPV commented May 11, 2022

Describe the bug
Seems like in this PR #44269 bt_gatt_write_without_response_cb was refactored so that it doesn't use func callback anymore. This brakes some mesh functionality which relies on the callback.

@PavelVPV PavelVPV added bug The issue is a bug, or the PR is fixing a bug area: Bluetooth Host labels May 11, 2022
@PavelVPV PavelVPV changed the title bt_gatt_write_without_rsp_cb doesn't use callback bt_gatt_write_without_response_cb doesn't use callback May 12, 2022
@hermabe
Copy link
Member

hermabe commented May 16, 2022

Looks like an oversight on my part. Does adding this line fix the issue?

bt_att_set_tx_meta_data(buf, func, user_data);

Commit with potential fix: hermabe@01ca4e3

@PavelVPV
Copy link
Collaborator Author

Yes, it works, checked on latest main. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Bluetooth Host bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants