[v2.7.x] Application defined Shell Command not registered

[th-fischer2020]

Describe the bug
I implemented some submodules in my Zephyr-Project with some shell command impelmentations. When i was still working on zephyr version 2.6.0 everything worked fine.

Now i did an Update to Zephyr 2.7.1 and later to 2.7.2. Since the Update i faced the problem, that my shell commands are gone. When i went back to 2.6.0 everything is fine again.

If the source files with my shell commands are moved to /src-directory (in project root), the shell commands are available again. Any other directorys are not working.
Another way to get back the commands is to create an shell_cmd.c file /src-directory (in project root) and include my shell-command-implementation-files like:

#include "my_cmd_1.c"
#include "my_cmd_2.c"

I think it has something to do with build-system settings (cmake)? Registration of the commands may not work, because in map-File i cannot find any symbols concerning my commands.
Additionally i did some tries with different gcc optimization settings but no success.

My project is based on a STM32F4 platform.

I am working with PlatformIO, but i think that is not a possible reason, because Zephyr 2.6.0 still works.

Expected behavior
My commands should appear in shell.

Impact
Key features are not available in my application. showstopper

Logs and console output
No logs. Shell commands not appear.

Environment (please complete the following information):

• OS: Ubuntu 20.04.4 LTS x86_64
• Toolchain: Platformio Core 5.2.5·Home 3.4.1
• Zephyr 2.7.2

[carlescufi]

@tfir1981 could you please try to see if this issue is present in the main branch as well?

[ThomasFike]

Have you verified that those files are being compiled when not in your src directory? You could check this quick by adding #error to one of the files. Then make sure you run a pristine build and see if it errors at the error you added. It sounds like the files are not being compiled from what your saying.

[th-fischer2020]

@ThomasFike

Have you verified that those files are being compiled when not in your src directory? You could check this quick by adding #error to one of the files. Then make sure you run a pristine build and see if it errors at the error you added. It sounds like the files are not being compiled from what your saying.

Yes, when my Code is not in src-directory it is compiled. On one hand i got an error if adding #error on other hand i can see compiler log. .o-File and .a-File were created.
Another test i did is adding an error inside of makro SHELL_CMD_REGISTER by changing symbolnames. It results in compiling error, too.

[th-fischer2020]

@carlescufi

@tfir1981 could you please try to see if this issue is present in the main branch as well?

Thanks for your reply. I did some tests:

I am using PlatformIO for development where it is not so easy to check out any Zephyr-Version. Finally i cloned the Zephyr-Example Repo Zephyr-Example and do compilation and flashing by using west.

I added a test command (myTestCmd.c)

#include <shell/shell.h>

static int testCmdFunc(const struct shell *pShell, size_t argc, char **argv)
{
  shell_print(pShell, "This is my very special testCmd");

  return 0;
}

SHELL_STATIC_SUBCMD_SET_CREATE(testCommands,
                               SHELL_CMD_ARG(status, NULL, "", testCmdFunc, 1, 0),

                               SHELL_SUBCMD_SET_END);

SHELL_CMD_REGISTER(testcommand, &testCommands, "My: Test shell commands", NULL);

I placed the file in app/src/myTestCmd.c. At this point my file is not compiled and my command is not visible on shell. I have to do some addition in app/CMakeLists.txt:

target_sources(app PRIVATE src/main.c src/myTestCmd.c)

In a second test i moved my command implementation to drivers directory. My command was not built until i added the following line to drivers/sensor/examplesensor/CMakeLists.txt :

zephyr_library_sources(myTestCmd.c)

I understand the necessary additions concerning cmake. Using west my command is visible on shell. Zephyr version does not matter.

I will do an another test by implementing a submodule. I will post the results later.

[th-fischer2020]

@carlescufi

I did another Test. To the example-application mentioned above i added a static lib in style of sample. I added another shell command implementation to this lib and i got it built and flashed. This Command appears in shell, too.

I think the Problem muss be on platformio side.

[th-fischer2020]

In my PlatoformIO i addes -Wl,--whole-archive to my build_flags. This is the solution.
Thanks for your help.
So this issue is solved for me.