Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESP32: PWM parameter renaming broke compilation #45886

Closed
Bl4d3s opened this issue May 23, 2022 · 2 comments · Fixed by #45888
Closed

ESP32: PWM parameter renaming broke compilation #45886

Bl4d3s opened this issue May 23, 2022 · 2 comments · Fixed by #45888
Assignees
@sylvioalves
Labels
area: PWM Pulse Width Modulation bug The issue is a bug, or the PR is fixing a bug platform: ESP32 Espressif ESP32 priority: low Low impact/importance bug

Comments

@Bl4d3s
Copy link
Contributor

Bl4d3s commented May 23, 2022

Describe the bug
Commit fbf73334f3 renamed parameters for the various pwm drivers to channel to unify these.
Unfortunately the esp32 driver already has some interal variable named "channel", thus breaking compilation.

  • Platform: Ubuntu WSL

To Reproduce
Steps to reproduce the behavior:

  1. mkdir build; cd build
  2. cmake -DBOARD=esp32
  3. make
  4. error: 'channel' redeclared as different kind of symbol

Expected behavior
Compilation to succeed

Impact
PWM on esp32 unusable

Environment (please complete the following information):

  • OS: Linux (Ubuntu WSL on Windows
  • Toolchain: Zephyr SDK
  • Commit SHA: e9d3791 (main)

Will submit PR shortly.
@Bl4d3s Bl4d3s added the bug The issue is a bug, or the PR is fixing a bug label May 23, 2022
@Bl4d3s Bl4d3s mentioned this issue May 23, 2022
Merged
@henrikbrixandersen henrikbrixandersen added area: PWM Pulse Width Modulation platform: ESP32 Espressif ESP32 has-pr labels May 23, 2022
@carlescufi carlescufi removed the has-pr label May 24, 2022
@mbolivar-nordic mbolivar-nordic added the priority: low Low impact/importance bug label May 24, 2022
@mbolivar-nordic
Copy link
Contributor

cc @gmarull

@gmarull
Copy link
Member

gmarull commented May 24, 2022

@mbolivar-nordic #45888

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sylvioalves sylvioalves

Labels
area: PWM Pulse Width Modulation bug The issue is a bug, or the PR is fixing a bug platform: ESP32 Espressif ESP32 priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ESP32: PWM: rename internal variable channel to avoid redeclaration Bl4d3s/zephyr
6 participants
@henrikbrixandersen @Bl4d3s @sylvioalves @carlescufi @gmarull @mbolivar-nordic