Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_maintainer.py incorrectly invoked by Github? #46345

Closed
marc-hb opened this issue Jun 7, 2022 · 3 comments
Closed

get_maintainer.py incorrectly invoked by Github? #46345

marc-hb opened this issue Jun 7, 2022 · 3 comments
Labels
area: Build System area: Scripts Scripts bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug

Comments

@marc-hb
Copy link
Collaborator

marc-hb commented Jun 7, 2022

In PR #44188, the MAINTAINERS.yml file should have added some SOF people, see lyakh, lgirdwood, marc-hb and kv2019i below. It did not. No one from the SOF team was aware of the very useful but backward-incompatible 44188 and it caused a (fortunately short-lived) Zephyr build failure in SOF CI.

@nashif, @cfriedt there seems to some get_maintainer.py-related glitch somewhere. Where is the get_maintainer.pyinvocation that assigns reviewers and the corresponding log for 44168?

PS: the "platform: Intel CAVS" github label was not automatically added either.

git checkout e4c171ed2255
./scripts/get_maintainer.py commits e4c171ed2255~5..e4c171ed2255

Intel Platforms (Xtensa)
	status: maintained
	maintainers: nashif
	collaborators: andyross, dcpleung, lyakh, lgirdwood, mengxianglinx, marc-hb, kv2019i, MaureenHelm
	inform: 
	labels: platform: Intel CAVS
	description: 

Twister
	status: maintained
	maintainers: nashif
	collaborators: chen-png, galak, PerMac, enjiamai, hakehuang, gopiotr
	inform: 
	labels: area: Twister
	description: 

West
	status: maintained
	maintainers: mbolivar-nordic
	collaborators: carlescufi, swinslow
	inform: 
	labels: area: West
	description: 

Originally posted by @marc-hb in #44188 (comment)

@marc-hb marc-hb added bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug area: Build System area: Scripts Scripts labels Jun 7, 2022
@nashif
Copy link
Member

nashif commented Jun 8, 2022

we do not use ./scripts/get_maintainer.py to assign reviewers, this is done manually at the moment and probably this PR was missed for some other reason, so this is an invalid bug.
The step is planned to be automated, but we are not there yet.

@nashif nashif closed this as completed Jun 8, 2022
@marc-hb
Copy link
Collaborator Author

marc-hb commented Jun 8, 2022

Interestingly, some "zephyrbot" just performed a large update to the list of reviewers of #44188. This update seems to match MAINTAINERS.yml but... days after 44188 was merged.
Screenshot 2022-06-08 at 06 57 31

@stephanosio
Copy link
Member

stephanosio commented Jun 8, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Build System area: Scripts Scripts bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Projects
None yet
Development

No branches or pull requests

3 participants