Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twister: regression : Failures are counted as errors #47702

Closed
tpennors opened this issue Jul 12, 2022 · 2 comments
Closed

twister: regression : Failures are counted as errors #47702

tpennors opened this issue Jul 12, 2022 · 2 comments
Assignees
Labels
area: Twister Twister bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug
Milestone

Comments

@tpennors
Copy link

Describe the bug
Failures are counted as errors. Must be a regression because it was working well before

To Reproduce
Steps to reproduce the behavior:

  1. Create a build error in zephyr/samples/hello_world/main.c
  2. run ./scripts/twister -T samples/hello_world/ -p b_u585i_iot02a
  3. See error:
    twister_error

Impact
The big problem is that as failure and error are inverted, twister return code is not 1 when failure occurs so CI does not pass in failure. As it can be seen in twister script:

if results.failed or (tplan.warnings and options.warnings_as_errors):
        sys.exit(1)

Environment (please complete the following information):

  • OS: OS: ubuntu 20.04
  • Toolchain zephyr-sdk 0.13.1
  • Commit SHA or Version : v3.1.0 TAG
@tpennors tpennors added the bug The issue is a bug, or the PR is fixing a bug label Jul 12, 2022
@carlescufi carlescufi added the area: Twister Twister label Jul 12, 2022
@nashif nashif modified the milestones: v3.0.1, v3.1.1 Jul 12, 2022
@nashif
Copy link
Member

nashif commented Jul 12, 2022

backport fix available, this is 3.1 specific.

@nashif
Copy link
Member

nashif commented Jul 26, 2022

#47703 merged

@nashif nashif closed this as completed Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Twister Twister bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug
Projects
None yet
Development

No branches or pull requests

3 participants