Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to loramac-node 4.7.0 when it is released to fix async LoRa reception on SX1276 #50603

Closed
dberlin opened this issue Sep 23, 2022 · 5 comments · Fixed by #50733
Closed
Assignees
Labels
area: LoRa bug The issue is a bug, or the PR is fixing a bug manifest-loramac-node priority: low Low impact/importance bug

Comments

@dberlin
Copy link

dberlin commented Sep 23, 2022

Right now, asynchronous LoRa reception on the SX1276 is broken because the payload buffer gets memset before the callback is run.
This pull request has more details.

A patch was submitted upstream to loramac-node to fix the issue there (rather than change zephyr's handling), and was accepted. It is targeted at the 4.7.0 release of loramac-node, so zephyr will need to upgrade once released in order to fix this bug.

I'm just opening an issue so it doesn't get lost.

Once 4.7.0 is released, i'm happy to prepare a pull request to do the update for zephyr.

@dberlin dberlin added the bug The issue is a bug, or the PR is fixing a bug label Sep 23, 2022
@JordanYates
Copy link
Collaborator

It is not necessarily required to wait for 4.7 to be released in order to fix the bug. In the past we have cherry-picked official commits that fix issues back to our current Zephyr branch. Unfortunately the hard freeze deadline for v3.2 has passed and I don't think this qualifies as a blocker-bug, but we would be able to fix it as soon as main opens up again.

@mmahadevan108
Copy link
Collaborator

@Mani-Sadhasivam, if you decide to cherry-pick this fix into the Lora module, then we might be able to get this in for 3.2 as this would be a bug fix.

@dberlin
Copy link
Author

dberlin commented Sep 27, 2022

FWIW - it's not a regression in the strictest sense because it never worked.
It has been broken on the 1276 since async receive was added :)

But it's definitely a bug fix, and it will be surprising to anyone who tries to use LoRa with zephyr, since it affects 100% of async receives on the sx127x. The sx127x chips (which silently fail) are much more popular than the sx126x series (which works).

IMHO, at a minimum, if it's not fixed, it should be noted as a known issue somewhere so people know to avoid it

@mmahadevan108 mmahadevan108 added the priority: low Low impact/importance bug label Sep 27, 2022
@Mani-Sadhasivam
Copy link
Member

@mmahadevan108 Done! #50733

@fabiobaltieri fabiobaltieri linked a pull request Sep 28, 2022 that will close this issue
@JordanYates
Copy link
Collaborator

JordanYates commented Dec 30, 2022

To be explicit for posterity, this was closed when updating to 4.6.0 with the async reception fix cherry picked on top, not with an upgrade to v4.7.0, which was not yet released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: LoRa bug The issue is a bug, or the PR is fixing a bug manifest-loramac-node priority: low Low impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants