Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP32: Compilation errors after migrating to zephyr 3.2.0 #54855

Closed
VineetaNarkhede-eaton opened this issue Feb 15, 2023 · 2 comments
Closed
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug platform: ESP32 Espressif ESP32 priority: low Low impact/importance bug

Comments

@VineetaNarkhede-eaton
Copy link

VineetaNarkhede-eaton commented Feb 15, 2023

Build error in dma_types.h and i2s_ll.h after migrating to zephyr 3.2.0
We have custom ADC code running on ESP32 using zephyr 3.1.0, now we are migrating to zephyr 3.2.0 and observed following errors in espressif module files i.e dma_types.h and i2s_ll.h

  1. Error in dma_types.h
    c:\workspace\zephyr-v3.2.0\modules\hal\espressif\components\hal\include\hal\dma_types.h:41:15: error: expected constructor, destructor, or type conversion before '(' token _Static_assert(sizeof(dma_descriptor_t) == 12, "dma_descriptor_t should occupy 12 bytes in memory");

This statement is same in zephyr 3.1.0 and 3.2.0

  1. Error in i2s_ll.h
    c:\workspace\zephyr-v3.2.0\modules\hal\espressif\components\hal\esp32\include\hal\i2s_ll.h:757:25: error: invalid conversion from 'unsigned int' to 'i2s_pdm_dsr_t' [-fpermissive] *dsr = hw->pdm_conf.rx_sinc_dsr_16_en;
    Function is modified in zephyr 3.2.0 as shown below:
    image
    I am able to fix this error by typecasting like *dsr = (i2s_pdm_dsr_t)hw->pdm_conf.rx_sinc_dsr_16_en;

Latest version of hal_espressif is having the same code in both files, I haven't seen the fix for these errors.

Please suggest the resolution for both errors as soon as possible.

Environment :

  • OS: Windows
  • Toolchain Zephyr SDK 0.15.2 , espressif 8.4.0 (C:\Users<username>.espressif\tools\zephyr)
@VineetaNarkhede-eaton VineetaNarkhede-eaton added the bug The issue is a bug, or the PR is fixing a bug label Feb 15, 2023
@nordicjm nordicjm added the platform: ESP32 Espressif ESP32 label Feb 15, 2023
@nashif nashif added the priority: low Low impact/importance bug label Feb 21, 2023
@sylvioalves
Copy link
Collaborator

@VineetaNarkhede-eaton, do you still face this issue? Have you run west update to make sure hal_espressif is updated?

@sylvioalves
Copy link
Collaborator

Checked ADC and it is properly working. Closing this. Open again if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug platform: ESP32 Espressif ESP32 priority: low Low impact/importance bug
Projects
None yet
Development

No branches or pull requests

4 participants