drivers: interrupt_controller: changes in shared irq

[nbalabak]

Updated the shared IRQ handler function in the shared interrupt controller drivers to include support for the 'irq_number' parameter. When a single driver manages multiple shared IRQs, it becomes challenging to determine which IRQ line is invoking the handler. Therefore, I've introduced an option to share the IRQ number to address this issue.

Signed-off-by: Navinkumar Balabakthan navinkumar.balabakthan@intel.com

[nbalabak]

@dcpleung @nashif Could you review this PR and provice your feedback?

[dcpleung]

Hm... this is going to be affecting everyone using this. Could you send out an email on the Zephyr dev mailing list to inform the community about the change? (to give them a heads up)

[henrikbrixandersen]

Looks good. Please add an entry in the migration guide for v3.6.0 detailing the needed changes to downstream code using this API.

[nbalabak]

Looks good. Please add an entry in the migration guide for v3.6.0 detailing the needed changes to downstream code using this API.

Hello @henrikbrixandersen
i raised one issue for this changes. is it fine or need to provide some other way to add entry?
#66613

[nbalabak]

Hm... this is going to be affecting everyone using this. Could you send out an email on the Zephyr dev mailing list to inform the community about the change? (to give them a heads up)

@dcpleung i sent email to Zephyr dev mailing list and inforamed about changes.

[henrikbrixandersen]

I raised one issue for this changes. is it fine or need to provide some other way to add entry?

#66613

You need to include the migration guide changes in this PR.

[nbalabak]

I raised one issue for this changes. is it fine or need to provide some other way to add entry?
#66613

You need to include the migration guide changes in this PR.

Hello henrik,
could you help how to do "include the migration guide changes" ?
is about explain api changes?

[henrikbrixandersen]

could you help how to do "include the migration guide changes" ?
is about explain api changes?

Yes, please add a description of the API change that may require end-users to update their out-of-tree code to this file: https://github.com/zephyrproject-rtos/zephyr/blob/main/doc/releases/migration-guide-3.6.rst

There are a few examples there already.

[nbalabak]

Hello henrik,
i updated mirgration guide could you review ?

[nbalabak]

Hello henrik,
i updated mirgration guide could you review ?

Hello @henrikbrixandersen could you please review changes

[nbalabak]

@MaureenHelm Could you please review this PR?

[henrikbrixandersen]

@nbalabak Please be patient. We will get to it. If in doubt, please see the contributor expectations (particularly the section on review escalation) here: https://docs.zephyrproject.org/latest/contribute/contributor_expectations.html#pr-review-escalation

[nbalabak]

@nbalabak Please be patient. We will get to it. If in doubt, please see the contributor expectations (particularly the section on review escalation) here: https://docs.zephyrproject.org/latest/contribute/contributor_expectations.html#pr-review-escalation

sure Thank you @henrikbrixandersen.

[henrikbrixandersen]

Suggested change

	* Interrupt_controller shared_irq public API function :c:func:`shared_irq_isr_register()`
	has changed. The parameter ``isr_func`` function pointer's parameter has modified.
	An addition irq_number parameter added to ``isr_func`` function pointer.
	* The function signature of the ``isr_t`` callback function passed to the ``shared_irq`` interrupt controller driver API via :c:func:`shared_irq_isr_register()` has changed. The callback now takes an additional `irq_number` parameter. Out-of-tree users of this API will need to be updated.

[nbalabak]

@henrikbrixandersen updated file as per your suggestion.