Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LE Audio: Scan Delegator shall clear metadata on meta_len = 0 #75080

Closed
Thalley opened this issue Jun 27, 2024 · 0 comments · Fixed by #75106
Closed

LE Audio: Scan Delegator shall clear metadata on meta_len = 0 #75080

Thalley opened this issue Jun 27, 2024 · 0 comments · Fixed by #75106
Assignees
Labels
area: Bluetooth Audio area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@Thalley
Copy link
Collaborator

Thalley commented Jun 27, 2024

Describe the bug
In the scan_delegator_mod_src we have the following

		/* If the metadata len is 0, we shall not overwrite the existing metadata */
		if (subgroups[i].metadata_len == 0) {
			continue;
		}

Which seems to be a leftover of a previous version of the BASS spec, as the version 1.0 does not state anything like that.

To Reproduce
N/A

Expected behavior
If the broadcast assistant sets the metadata_len to 0, we should clear the metadata instead.

Impact
Missing spec compliance

Logs and console output
N/A

Environment (please complete the following information):

  • Commit SHA or Version used: ee451e5

Additional context
N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Bluetooth Audio area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant