Fixes some logical issues in matrix and vector code #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds missing `break` statements in `zsl_mtx_binary_op`. Signed-off-by: Kevin Townsend <kevin@ktownsend.com>
Fixes two small logical errors in `zsl_vec_sort` and `zsl_vec_zte`. Signed-off-by: Kevin Townsend <kevin@ktownsend.com>
microbuilder
added
category:bug
|
@uLipe When you have a few minutes, do you mind doing a quick check of these and approve if you're happy with the changes? I completely missed the issues that were raised in January (thanks @ruehlchris). |
uLipe
reviewed
May 28, 2023
| @@ -372,7 +372,7 @@ int zsl_vec_zte(struct zsl_vec *v) | |||
|
|
|||
| for (size_t g = 0; g < v->sz; g++) { | |||
| if ((v->data[g - x] >= 0.0 && v->data[g - x] < epsilon) || | |||
| (v->data[g - x] <= 0.0 && v->data[g - x] > epsilon)) { | |||
| (v->data[g - x] <= 0.0 && v->data[g - x] > -epsilon)) { | |||
There was a problem hiding this comment.
nitpick: It seems this is a saturation operation, if so I would not use less/greater and equal, since we only want to wrap around to a desired value when the variable surpasses it.
uLipe
reviewed
May 28, 2023
uLipe
approved these changes
May 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address some small logical and code problems identified in the issues below:
Fixes #46
Fixes #47
Fixes #48