Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

attempting to repair a part doesn't do anything #30

Open
zer0Kerbal opened this issue Sep 27, 2021 · 6 comments
Open

attempting to repair a part doesn't do anything #30

zer0Kerbal opened this issue Sep 27, 2021 · 6 comments
Assignees
@zer0Kerbal
Labels
help wanted assistance, help, input solicited
Projects
2.2.99.0-prerelease Flyswatter (Bug and Feature Triage)

Comments

@zer0Kerbal
Copy link
Owner

@Zelda from forums here

Describe the bug
A clear and concise description of what the bug is.

attempting to repair a part doesn't do anything. There is an NRE in the log for each attempt:

[LOG 05:46:45.770] [OhScrap]: Attempting repairs [EXC 05:46:45.771] NullReferenceException: Object reference not set to an instance of an object OhScrap.ModuleUPFMEvents.RepairFailCheck () (at <ff6d23eb118f4e0182b4a8802c697e52>:0) OhScrap.ModuleUPFMEvents.RepairChecks () (at <ff6d23eb118f4e0182b4a8802c697e52>:0) BaseEvent.Invoke () (at <06f13185617646e5bc801baeab53ab75>:0) RemoteTech.Modules.ModuleSPU.InvokeEvent (BaseEvent baseEvent, System.Boolean ignoreDelay) (at <f874303228fc4dd4a4a51810517e0aa8>:0) RemoteTech.FlightComputer.UIPartActionMenuPatcher+EventWrapper.Invoke () (at <f874303228fc4dd4a4a51810517e0aa8>:0) BaseEvent.Invoke () (at <06f13185617646e5bc801baeab53ab75>:0) UIPartActionButton.OnClick () (at <06f13185617646e5bc801baeab53ab75>:0) UnityEngine.Events.InvokableCall.Invoke () (at <5aeafee3fea24f37abd1315553f2cfa6>:0) UnityEngine.Events.UnityEvent.Invoke () (at <5aeafee3fea24f37abd1315553f2cfa6>:0) UnityEngine.UI.Button.Press () (at <8485d97123094db9883b53b3349c2a3b>:0) UnityEngine.UI.Button.OnPointerClick (UnityEngine.EventSystems.PointerEventData eventData) (at <8485d97123094db9883b53b3349c2a3b>:0) UnityEngine.EventSystems.ExecuteEvents.Execute (UnityEngine.EventSystems.IPointerClickHandler handler, UnityEngine.EventSystems.BaseEventData eventData) (at <8485d97123094db9883b53b3349c2a3b>:0) UnityEngine.EventSystems.ExecuteEvents.Execute[T] (UnityEngine.GameObject target, UnityEngine.EventSystems.BaseEventData eventData, UnityEngine.EventSystems.ExecuteEvents+EventFunction1[T1] functor) (at <8485d97123094db9883b53b3349c2a3b>:0)
UnityEngine.DebugLogHandler:LogException(Exception, Object)
ModuleManager.UnityLogHandle.InterceptLogHandler:LogException(Exception, Object)
UnityEngine.EventSystems.EventSystem:Update()`

To Reproduce
Steps to reproduce the behavior:

  1. KSP 1.11.2, and I've tried OhScrap! versions 2.1.1.1 and 2.2.0.0
  2. have remotetech installed
  3. part failure of an antennae
  4. try to repair antennae with OHS
  5. See error

**RemoteTech.Modules.ModuleSPU.InvokeEvent

**
Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):
Maybe related to RemoteTech somehow? Not sure, might be totally unrelated.

I'm on KSP 1.11.2, and I've tried OhScrap! versions 2.1.1.1 and 2.2.0.0. Full log file here: https://1drv.ms/u/s!AmAxSBcQL19WnvoukqOS8usH3wpd3A?e=BrdDkv. If there is any other info you'd like, please let me know!
KSP.OhScrap.log

installed mods:

  1. Stock assembly: Assembly-CSharp v0.0.0.0
  2. ModuleManager v4.2.1.0
  3. ClickThroughBlocker v0.1.10.17
  4. FilterExtensions v3.2.6.0 / v1.0.0.0
  5. BlendshapeModelLoader v1.0.0.0
  6. TexturesUnlimited v0.0.0.0
  7. aaa_Toolbar v1.8.0.5
  8. ToolbarControl v0.1.9.4 / v1.0.0.0
  9. AnyResContinued v2.0.7.2
  10. Sigma88LoadingScreens v0.5.0.0
  11. SigmaReplacementsSkyBox v1.0.0.0
  12. B9AnimationModules v1.7.0.0 / vv1.7.0
  13. B9PartSwitch v2.17.0.0 / vv2.17.0
  14. BDAnimationModules v0.6.6.0
  15. RNModules v1.1.9.0
  16. WearableProps v1.0.0.0
  17. KSP_Log v0.1.1.7
  18. BetterLoadSaveGame v2.5.3.3
  19. SigmaTweakMaxResource v1.0.0.0
  20. BetterTimeWarp v2.3.12.5
  21. CameraTools v1.18.2.0 / v1.18.2
  22. Chatterer v0.9.99.2788
  23. CCK v4.0.0.0 / v4.0.0.0 for KSP 1.5.0
  24. ConformalDecals v1.0.0.0 / v1.0.0
  25. ContractConfigurator v1.0.0.0 / v1.30.5
  26. RemoteTech v1.9.0.0 / v1.9.11
  27. CC_RemoteTech v1.0.0.0 / v1.30.5
  28. KXAPI v1.0.0.0
  29. CraftManager v1.0.7240.23210
  30. KatLib v1.0.7240.21438
  31. CrewQueueTwo v1.1.11.2
  32. SimpleBoiloff v0.2.1.0
  33. CustomAsteroids v1.9.0.0
  34. CustomBarnKit v1.1.21.0
  35. DatedQuickSaves v1.2.4.4 / v1.1.5.0
  36. DecouplerShroud v1.0.0.0
  37. DeployableEngines v2.2.0.0
  38. DestructionEffects v1.12.0.0
  39. DistantObject v2.0.2.0
  40. DMagic v1.4.3.0 / vv1.4.3.0
  41. DynamicBatteryStorage v1.0.0.0
  42. FlightTracker v1.0.0.0
  43. EarnYourStripes v1.0.0.0
  44. EditorExtensionsRedux v3.4.3.5
  45. EditorTime v1.0.6.0
  46. EngineLightRelit v1.6.3.0 / v1.0.0.0
  47. Atmosphere v1.11.3.1
  48. CelestialShadows v1.11.3.1
  49. CityLights v1.11.3.1
  50. EVEManager v1.11.3.1
  51. PartFX v1.11.3.1
  52. PQSManager v1.11.3.1
  53. ShaderLoader v1.11.3.1
  54. Terrain v1.11.3.1
  55. TextureConfig v1.11.3.1
  56. Utils v1.11.3.1
  57. _BuildManager v1.11.3.1
  58. Firespitter v7.3.7660.26532
  59. FP_DockingSndFX v2.1.12.27690
  60. HideEmptyTechTreeNodes v1.0.0.0
  61. HullcamVDSContinued v0.2.1.2
  62. JanitorsCloset v0.3.7.7 / v1.0.0.0
  63. JSIPartUtilities v0.5.0.4 / v0.0.3.103
  64. RasterPropMonitor v0.31.5.22299
  65. KerbalChangelog v1.4.2.0
  66. KerbalConstructionTime v1.4.9.0
  67. KerbalEngineer.Unity v1.0.0.0
  68. KerbalEngineer v1.1.9.0
  69. KerbalJointReinforcementNext v4.1.15.0
  70. KerbalObjectInspector v1.1.8.1 / v1.0.0.0
  71. HyperEdit v1.5.8.0 / v1.5.8
  72. ModularFlightIntegrator v1.0.0.0 / v1.2.10.0
  73. KerbalWeatherProject v1.0.0.0
  74. KiwiTechTree v1.0.0.0
  75. Kopernicus.Parser v1.0.0.0
  76. Kopernicus v1.0.0.0
  77. kOS v1.3.2.0
  78. kOS-Career v0.1.0.0
  79. KOS-Scansat v1.2.0.0
  80. kOS.AddOns.StockCamera v0.2.0.0
  81. ICSharpCode.SharpZipLib v0.86.0.518 / v0.86.0
  82. kOS.Safe v1.3.2.0
  83. KRASH v0.5.33.5
  84. Kopernicus.Parser v1.0.0.0
  85. Kronometer v1.0.0.0
  86. KSPRescueContractFix v1.1.0.0
  87. KSP-PartVolume v0.0.2.8
  88. KatLib v1.0.7240.21438
  89. LightsOut v0.3.0.1
  90. MagiCore v1.3.2.3 / v1.0.0.0 / v1.3.1.0
  91. MechJeb2 v2.5.1.0 / v / v2.12.3.0
  92. System.Buffers v4.0.3.0 / v4.6.28619.01 @BuiltBy: dlab14-DDVSOWINAGE069 @Branch: release/2.1 @srccode: https://github.com/dotnet/corefx/tree/7601f4f6225089ffb291dc7d58293c7bbf5c5d4f / v4.6.28619.01
  93. MemorialWall v0.0.0.0
  94. DockingPortAlignmentIndicator v6.9.2.2
  95. DPAI_RPM v1.0.0.2
  96. ModuleDockingNodeNamed v1.0.0.2
  97. NearFutureElectrical v1.0.0.0
  98. NearFutureExploration v0.4.0.0
  99. NFPropUtils v1.0.0.0
  100. NearFuturePropulsion v0.9.0.0
  101. NearFutureSolar v0.4.0.0
  102. NearFutureUtils v0.0.0.0
  103. NeptuneCamera v1.0.0.0
  104. OhScrap v2.2.0.0 / v2.2.0.3
  105. PartInfo v0.0.6.1 / v1.0.0.0
  106. PersistentRotation v1.3.1.0
  107. PlanetShine v0.2.6.1
  108. PreciseNode v1.2.11.2
  109. ProceduralFairings v6.0.0.0 / v6.1.0.0
  110. ProjectManager v1.0.0.0
  111. QuickExit v2.2.0.8
  112. RCSBuildAid v1.0.6.35359
  113. RCSBuildAidToolbar v1.0.6.35359
  114. RealChute v1.4.7691.3806 / v1.4.8.2
  115. ReentryParticleEffectRenewed v1.8.1.0
  116. ResonantOrbitCalculator v0.0.6.2 / v1.4.4.0
  117. Restock v0.1.0.0
  118. SCANsat v1.20.4.0 / vv20.4
  119. SCANmechjeb v1.20.4.0 / vv20.4
  120. SCANsat.Unity v1.20.4.0
  121. scatterer v0.772.0.0
  122. ScienceParamModifier v1.0.12.0 / vv12
  123. ScrapYard v2.2.0.0 / v2.2.0.5
  124. ScrapYard_ContractConfigurator v2.2.0.0
  125. 0Harmony v1.2.0.1
  126. Shabby v0.1.2.0 / v0.1.2
  127. SigmaDimensions v1.0.0.0
  128. SimpleAdjustableFairings v1.12.0.0 / vv1.12.0
  129. SmokeScreen v2.8.14.0
  130. SolverEngines v3.3.0.0 / v3.10.0.0
  131. SoundtrackEditorForked v4.7.1.4 / v4.6.0.0
  132. ButtonManager v0.0.1.1
  133. KSP_ColorPicker v0.1.0.4
  134. KSP_PartHighlighter v0.1.0.9
  135. SpaceTuxUtility v0.0.3.1
  136. VesselModuleSave v0.0.1.2
  137. Stock assembly: KSPSteamCtrlr v0.0.1.35
  138. StagedAnimation v1.0.0.0
  139. StageRecovery v1.9.5.3 / v1.8.0.0
  140. HabUtils v1.0.0.0
  141. SystemHeat v0.1.0.0
  142. TarsierSpaceTech v7.12.0.0
  143. TextureReplacer v4.5.1.34170
  144. BetterTracking v1.0.6.0 / v6.0
  145. BetterTracking.Unity v1.0.6.0
  146. KerbalAlarmClock v3.13.0.0
  147. TransferWindowPlanner v1.7.2.0
  148. TrimIndicators v0.1.0.3 / v1.0.0.0
  149. TUFX v1.0.0.0
  150. UniversalStorage2 v1.8.0.0 / vv1.8.0.0
  151. UniversalStorage2.Unity v1.8.0.0
  152. Waterfall v0.0.0.0
  153. WaypointManager v2.8.3.1 / v2.8.1
  154. SnacksUtils v1.0.0.0
  155. ZeroMiniAVC v1.1.0.2
  156. [x]_Science! v6.0.0.8
@zer0Kerbal zer0Kerbal added bug help wanted assistance, help, input solicited labels Sep 27, 2021
@zer0Kerbal zer0Kerbal added this to the Repair part exception milestone Sep 27, 2021
@zer0Kerbal zer0Kerbal self-assigned this Sep 27, 2021
@zer0Kerbal zer0Kerbal added this to To do in 2.2.99.0-prerelease via automation Sep 27, 2021
@zer0Kerbal
Copy link
Owner Author

@Zelda
thank you, 🤔 💭 I will attempt to replicate error, but only with OHS+SYD+RemoteTech installed.

@zer0Kerbal zer0Kerbal moved this from To do to In progress in 2.2.99.0-prerelease Sep 28, 2021
@zer0Kerbal
Copy link
Owner Author

looks like part of the problem is the RemoteTechWrapper.cs has been updated.

@zer0Kerbal zer0Kerbal moved this from Needs triage to High priority in Flyswatter (Bug and Feature Triage) Sep 30, 2021
@physius
Copy link

physius commented Oct 5, 2021

I'm having this same issue, but without RemoteTech. I'll try to pin it down.

@JadeFalcon-1
Copy link

Experiencing the same issue, without Remotetech, but on 1.9.1, logs in link below:
https://www.dropbox.com/s/vjq8kru16por9ig/Oh%20Scrap%20Error.7z?dl=0

@JadeFalcon-1
Copy link

Noted that this issue only seems to occur with engineers, any other kerbal can try and succeed.

@CovertJaguar
Copy link

looks like part of the problem is the RemoteTechWrapper.cs has been updated.

Only change was:

fcAttCom_t = rtFliCom_t.GetProperty("CurrentFlightMode", BindingFlags.Instance | BindingFlags.Public); 
//changed currentFlightMode to CurrentFlightMode

markusa380/PersistentRotation@9e56f8d#diff-e804eca566167c2f4a1c5b475218979bd004fd2bfb32cda98801f591b8574544R88

Just want to also state that I'm getting the same errors.

@settings settings bot removed bug labels Aug 11, 2022
@settings settings bot removed this from the Repair part exception milestone Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zer0Kerbal zer0Kerbal

Labels
help wanted assistance, help, input solicited
Projects
Flyswatter (Bug and Feature Triage)
  
High priority
2.2.99.0-prerelease
  
In progress
Milestone
No milestone
Development

No branches or pull requests
4 participants
@CovertJaguar @physius @JadeFalcon-1 @zer0Kerbal