Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Kerbalism config #90

Closed
zer0Kerbal opened this issue May 2, 2023 · 2 comments · Fixed by #93
Closed

[BUG] Kerbalism config #90

zer0Kerbal opened this issue May 2, 2023 · 2 comments · Fixed by #93
Assignees
@Rodg88 @zer0Kerbal
Labels
bug 🐛 An issue with the system. Something isn't working... KSC... we have an error code issue: compatibility/patch issue type issue: config issue type
Projects
1.4.3.0-release
Milestone
1.4.3.0-release

Comments

@zer0Kerbal
Copy link
Owner

Rodger

Posted 40 minutes ago
Come across an issue where this mod is using FOR[KerbalismDefault] instead of NEEDS[KerbalismDefault], so it's declaring the pass that other patches are looking for to enable kerbalism compat. FOR should only really be used by the mod itself.

Should be a simple fix, I think it's only in Compatibility/Kerbalism.cfg

image
@zer0Kerbal zer0Kerbal added issue: compatibility/patch issue type issue: config issue type bug 🐛 An issue with the system. Something isn't working... KSC... we have an error code labels May 2, 2023
@zer0Kerbal zer0Kerbal self-assigned this May 2, 2023
@zer0Kerbal zer0Kerbal added this to To do in 1.4.2.2-release via automation May 2, 2023
@zer0Kerbal zer0Kerbal added this to Needs triage in Flyswatter (Bug and Feature Triage) via automation May 2, 2023
@zer0Kerbal
Copy link
Owner Author

https://github.com/zer0Kerbal/MiniSampleReturnCapsule/blob/990bc45e32d4d5feec15f1847343d6d5dffb0c47/GameData/MiniSampleReturnCapsule/Compatibility/Kerbalism.cfg

@Rodg88
Copy link

Rodg88 commented May 3, 2023

This is my github account, thanks

@zer0Kerbal zer0Kerbal removed this from To do in 1.4.2.2-release May 7, 2023
@zer0Kerbal zer0Kerbal added this to To do in 1.4.3.0-release via automation May 7, 2023
@zer0Kerbal zer0Kerbal moved this from Needs triage to High priority in Flyswatter (Bug and Feature Triage) May 7, 2023
@zer0Kerbal zer0Kerbal removed this from High priority in Flyswatter (Bug and Feature Triage) May 7, 2023
@zer0Kerbal zer0Kerbal moved this from To do to In progress in 1.4.3.0-release May 7, 2023
@zer0Kerbal zer0Kerbal added this to the 1.4.3.0-release milestone May 7, 2023
@zer0Kerbal zer0Kerbal mentioned this issue May 8, 2023
Merged
1.4.3.0-release automation moved this from In progress to Done May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rodg88 Rodg88

@zer0Kerbal zer0Kerbal

Labels
bug 🐛 An issue with the system. Something isn't working... KSC... we have an error code issue: compatibility/patch issue type issue: config issue type
Projects
Flyswatter (Bug and Feature Triage)
Status: Done
1.4.3.0-release
  
Done
Milestone
1.4.3.0-release
Development

Successfully merging a pull request may close this issue.

Version 1.4.3.0-release - <Scanning Rodger, Rodger> edition zer0Kerbal/MiniSampleReturnCapsule
2 participants
@Rodg88 @zer0Kerbal