Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date format depends on system locale? #28

Closed
kylrth opened this issue Apr 1, 2020 · 3 comments
Closed

Date format depends on system locale? #28

kylrth opened this issue Apr 1, 2020 · 3 comments

Comments

@kylrth
Copy link

kylrth commented Apr 1, 2020

I tried several times to create a new token with an expiry date, but the token wouldn't work. I was running the module (python -m matrix_registration gen -e 01.04.2020). When I tried using the /token API, I realized that I was actually getting a token with expiry on Jan 04, 2020! It sounds like the date formatter might depend on my system locale or something like that. Can we fix it so the format is always DD.MM.YYYY?

@zeratax
Copy link
Owner

zeratax commented Apr 8, 2020

Probably should just change it to ISO 8601 so YYYY.MM.DD since that should be unambiguous everywhere

@kylrth
Copy link
Author

kylrth commented Apr 13, 2020

Yes, that would be best.

@zeratax
Copy link
Owner

zeratax commented Jun 12, 2020

fixed in 588025d with will be in the shortly coming v0.6.0

@zeratax zeratax closed this as completed Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants