[WIP] header explicitly add content #147
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So ein biscchen frage ich mich auch, ob es soo viel Sinn macht den Headercontent als String zu übergeben, weil man den dann im Prinzip auch direkt in Source reinklatschen könnte. Aber ich glaube bei komplexeren Kernels kann es vielleicht doch sinnvoll sein. |
Ja also das hier macht halt wirklich nur Sinn, wenn man ne binary am ende haben will, wo dann beim enduser die header nicht mehr auf der festplatte sind sondern nur noch in der binary |
zeratax
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!fixes #70
!fixes #72
really wish I knew how to use constexpr like at all: https://github.com/ZerataX/yacx/blob/447ddb3e8392668b9a3bd29cbba2d33316ba7b6e/include/yacx/Headers.hpp#L21
if this was constexpr it would make it really clear that using e.g.
loadis a bad idea, but I have no clue how. If no one knows, just move this to a new issueprobably a neater way to check if both sides of the pair are castable to string
https://github.com/ZerataX/yacx/blob/447ddb3e8392668b9a3bd29cbba2d33316ba7b6e/include/yacx/Headers.hpp#L37-L43
maybe even by using https://github.com/ZerataX/yacx/blob/master/include/yacx/util.hpp#L23-L29
Still can't test anything :/