Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not sending text for the checkbox field in the e-mail (only the Label is present) #1

Closed
Porscha-joomla opened this issue Apr 4, 2018 · 7 comments

Comments

@Porscha-joomla
Copy link

Porscha-joomla commented Apr 4, 2018

Hi! The plugin is great. There are two things that I noticed:

  1. In the plugin there is this sentence: "This plugin lets you create new fields of type 'checkbox' in any extensions where custom fields are supported." Maybe it's better to say "This plugin lets you create new fields of type 'privacycheckbox ' in any extensions where custom fields are supported." Because when somebody creates a custom field, it must be with type Privacy Checkbox (privacycheckbox), not only checkbox.

  2. After a privacy checkbox field is created and a text with tags is placed in Checkbox Note, the permissions for Edit Custom Field Value are set to Allow, the contact form is ready for sending messages. When I tested it in the received e-mail in the site owner inbox, there is only a row with checkbox filed label, but there is no value and text for this field - basically the Checkbox note text is not in the email.

  3. Default Value - it must not be filled, because the user freely has to give his permission, so for what is this field for?

@Porscha-joomla Porscha-joomla changed the title Not sending text for the checkbox field in the e-mail (only the title is present) Not sending text for the checkbox field in the e-mail (only the Label is present) Apr 4, 2018
@zero-24 zero-24 closed this as completed in f5a0809 Apr 4, 2018
@zero-24
Copy link
Owner

zero-24 commented Apr 4, 2018

Default Value - it must not be filled, because the user freely has to give his permission, so for what is this field for?

Joomla Core Custom Fields Field that all Custom Fields have

After a privacy checkbox field is created and a text with tags is placed in Checkbox Note, the permissions for Edit Custom Field Value are set to Allow, the contact form is ready for sending messages. When I tested it in the received e-mail in the site owner inbox, there is only a row with checkbox filed label, but there is no value and text for this field - basically the Checkbox note text is not in the email.

As you have pointed out on 3 there is no default value so nothing to add here ;) As it is required to check that box you can not send a mail without it :)

In the plugin there is this sentence: "This plugin lets you create new fields of type 'checkbox' in any extensions where custom fields are supported." Maybe it's better to say "This plugin lets you create new fields of type 'privacycheckbox ' in any extensions where custom fields are supported." Because when somebody creates a custom field, it must be with type Privacy Checkbox (privacycheckbox), not only checkbox.

Yes you are correct fixed with: f5a0809

@Porscha-joomla
Copy link
Author

But after you check it and send the mail, the email receiver receives an email with all data as Name, Email and message, but the row where checkbox is, has only a label and :
Example:
I have a label called: Privacy Policy agreement
and Checkbox note: I consent to site storing and using my personal information to get back in touch with me. Link to Privacy Policy
and in email which is received there is only Privacy Policy agreement: You do not have the sentence for the agreement.
I do not know if I explained it very well.

@zero-24
Copy link
Owner

zero-24 commented Apr 4, 2018

hmm I'm going to check that with a bit more time.

@zero-24 zero-24 reopened this Apr 4, 2018
@Porscha-joomla
Copy link
Author

Porscha-joomla commented Apr 4, 2018

Thank you! Maybe create a field with label and checkbox note, send an email and look at the email to see the last row in it should be the one with the custom field , but I personally have only the label in the mail.

@zero-24 zero-24 closed this as completed in a7217df Apr 7, 2018
@zero-24
Copy link
Owner

zero-24 commented Apr 7, 2018

There is now a dedicated option for that text. In case nothing is there the Text "Checked" (PLG_FIELDS_PRIVACYCHECKBOX_CHECKBOX_CHECKED) is used.

a7217df

Thanks for your suggestion.

@zero-24
Copy link
Owner

zero-24 commented Apr 7, 2018

A new release including the change above got just published: https://github.com/zero-24/plg_fields_privacycheckbox/releases/tag/1.0.3
You can use the Joomla Updater from the Backend to update the plugin.

@zero-24 zero-24 added this to the PrivacyCheckbox 1.0.3 milestone Apr 7, 2018
@Porscha-joomla
Copy link
Author

Just great! Thank you @zero-24 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants