-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automask by layer for img2img #169
Comments
so i'm definitely missing what you're doing here; of course we say that img2img is definitely not intended for outpainting, but i've just tried dumping manual masking around a transparent stamp and trying the different inpaint modes and wow none of them turned out good at all lol; can you post some examples/use case/maybe a small "tutorial" to do what you're doing manually? i'm not AGAINST the img2img tool being used for outpainting but yeah, that's currently the dream tool's domain |
The problem with generating anything outside the existing image is that steps will be scaled according to denoising. Even if we fix the more obvious issue by manually introducing noise in an otherwise 'original' masking query, if you use 30 SD steps with 0.7 denoising with a half-empty area, that area we introduced latent noise to would be run through only ~17ish steps. |
Actually, I guess this is because I am using it as an inpainting and as an art program rather than just an outpainting tool. Let me give some use cases, hopefully you can think of a better way than what I proposed:
The idea is that I want the mask to cut the extra stuff generated and utilize the alpha channel as a masking tool. |
Oh, so you mean a 'keeptransparent' option? Like, what was transparent before continues transparent now? If so, that we can probably do that. But as img2img uses the full visible info, not sure what layer-by-layer would actually do, and would make things very complex. |
I think the best option regarding masking by layer in this case would be to add two buttons to the mask brush like 'masktransparent' and 'maskcontent' that creates masks based on the currently selected layer. Adding a mask button to the layers themselves would be heck to implement (what would happen if one tried to erase layer masking, and would there be any visual hints regarding masked layers?, Etc...) |
What if it was in the img2img context menu? An option to: So when img2img finishes generating, the extra parts get cut based on selection. |
This is something I usually need when I draw something with a brush, or when I use a stamp with alpha channel.
I want to apply img2img without adding a black background.
This is still possible by using the mask brush, but it is tedious and very inaccurate.
My suggestion is to add an option besides the visibility of the layer to apply layer mask
![image](https://user-images.githubusercontent.com/4189008/212245392-2056f0fe-8362-45ad-b90b-9d16fbc562ba.png)
The text was updated successfully, but these errors were encountered: