Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: #230

Open
ZZZephyriusss opened this issue Apr 22, 2023 · 4 comments
Open

[Feature Request]: #230

ZZZephyriusss opened this issue Apr 22, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@ZZZephyriusss
Copy link

ZZZephyriusss commented Apr 22, 2023

Is your feature request related to a problem? Please describe.

When i make a inpaint with mask opn, the red parts is generated...but when there is no red inside ...there is still a generation that is launch for nothing. I am using your incredible app for month now but i still get trap in this : Yes i know, it turns blue but There is no point of lauching an inpaint with "mask on" if there is no masked area inside the rectangle selection.

----One way of doing that could be : the borders of the inpaint rectangle are red, and they turns blue if i hoover the rectangle where there is red mask zone in it. Like that that, we don't have to constantly shift from one mode to the others and make mistake and launch empty generations.

Describe the solution you'd like

Instead, the best way will be, if the selection rectangle is empty, it flips automatiquely as if "mask" was on blue..it will saved so much time !!! no more accidental empty generations

Proposed workflow

----=
I put a the inpaint rectangle selection in a area with no mask brushes strokes : it make the whole selection generated with the gradient border.
----=
I put a the inpaint rectangle selection in a area with mask strokes : it make only the red brushed zone selection generated , with no gradient border.

Describe alternatives you've considered

----One way of doing that could be : the borders of the inpaint rectangle are red, and they turns blue automaticly if i hoover the rectangle where there is red mask zone in it.

Like that that, we don't have to constantly shift from one mode to the others and make mistake and launch empty generations.

The Easy solution : If there is no masked area inside the rectangle selection, a message appear in front of the screen : "no masked area detected, do you wish to switch mode ?"

Additional context

Hey, really thank you for your work, i am a big fan of your app, i used it constantly, i think it is much better than Invoke !! Thanks a lot

@ZZZephyriusss ZZZephyriusss added the enhancement New feature or request label Apr 22, 2023
@zero01101
Copy link
Owner

so i believe what you're describing should actually already be how it works, but you may need to toggle the invert mask function (unless i've completely missed the point which is very plausible lol)

@ZZZephyriusss
Copy link
Author

ZZZephyriusss commented Apr 25, 2023

actually no. the problem i am talking about is that when you have invert mask function off, and you select a square with no red brush inside it will go to the process of "dreaming" to output nothing. I now that i have to toggle the invert mask function when there is no red mask area but that is the point : if there is nothing to render, why it is not detected and inverted automatically ? it is a mistake that i still make even after month. but okay thanks for your response

@zero01101
Copy link
Owner

it definitely shouldn't output nothing/identical if there's no manually placed mask and the invert function is set to its default enabled state, which would be implying "the whole section is masked" when no mask is drawn - check out #209 (comment) for a very brief example - just to be sure, you're using the img2img tool and not dream, right?

@ZZZephyriusss
Copy link
Author

yes , the img to img tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants