This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Fix return type for DataFrame.groupBy / cube / rollup #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @dangercrow
There is quite a bit of history between these two, and cherry picking might get tricky. Please make sure that your PR passes CI build. |
zero323
reviewed
May 19, 2019
I should really install a proper IDE on my machine.
|
FYI I did also have plans to update the |
Please be sure to check #2 first. At the moment all annotations for comparison dunder methods are explicitly ignored. |
|
LGTM, thank you. Merged into branch-2.3, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.3 has these data types and I was erroneously gettting errors for them.
Note this is a port of e2d225f
I tried a cherry-pick but it had some issues (not sure why)