This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Overload DataFrame.drop: sequences must be *str #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zero323
reviewed
Feb 17, 2020
|
Nice catch. I thought we might resolve it upstream, but this would require an additional signature in Scala, and it might be a hard to sell. |
|
Well, you carry more weight in the Spark development circles, but I think you're right. It’s a nice to have. With this PR, I’m hoping it eases development for some. Thanks for the review, zero323! |
I seriously doubt that :) |
zero323
pushed a commit
that referenced
this pull request
Feb 17, 2020
* Overload DataFrame.drop: sequences must be *str
|
Merged into master, backported to 2.4. Thanks your work! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
DataFrame.dropexpects either 1Column, or 1str, or an iterable of strings. This is only type checked inside the function though.Currently the type hints (and the actual API) allow to pass multiple
Columns but it does result in a runtime error. Personally, I'd like to have that caught earlier. But as this might be getting too close to the internals of the functions, I’d like to hear your opinion on whether or not the type hints should “look inside” to aid development.