Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zmq_proxy incorrect declaration #279

Closed
ADDubovik opened this issue Nov 16, 2018 · 9 comments
Closed

zmq_proxy incorrect declaration #279

ADDubovik opened this issue Nov 16, 2018 · 9 comments

Comments

@ADDubovik
Copy link

zmq_proxy declaration is incompatible with original declaration (there's should be "const" added).

@sigiesec
Copy link
Member

I am not sure what you mean, where is the incompatible declaration and where is the original?

@ADDubovik
Copy link
Author

http://api.zeromq.org/4-2:zmq-proxy :
int zmq_proxy (const void *frontend, const void *backend, const void *capture);

ZMQ.h :
ZMQ_EXPORT int zmq_proxy (void *frontend_, void *backend_, void *capture_);

@kurdybacha
Copy link
Contributor

@sigiesec I believe this is about arguments' constness.

  • libzmq:
    int zmq_proxy (const void *frontend, const void *backend, const void *capture);
  • cppzmq has no const arguments:
    inline void proxy(void *frontend, void *backend, void *capture)

@sigiesec
Copy link
Member

Hm, the libzmq documentation is wrong, the arguments are not declared const in zmq.h:
https://github.com/zeromq/libzmq/blob/f21bae529e7e62ab51c97375681db89de055c3ed/include/zmq.h#L525

@ADDubovik
Copy link
Author

Oh, really.
Should I create an issue in libzmq?

@sigiesec
Copy link
Member

I fixed the documentation: zeromq/libzmq#3422

@sigiesec
Copy link
Member

I think this issue can the be closed, right?

@ADDubovik
Copy link
Author

There's also erraneous WEB-documentation (http://api.zeromq.org/4-2:zmq-proxy).

@sigiesec
Copy link
Member

I don't know if libzmq 4.2.x is still maintained. With the next libzmq release, new 4.3 docs will probably be generated by the maintainers. But this isn't a cppzmq issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants