Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specfile doesn't work for multi-core machines #50

Closed
cdman opened this issue Jun 8, 2011 · 4 comments
Closed

Specfile doesn't work for multi-core machines #50

cdman opened this issue Jun 8, 2011 · 4 comments

Comments

@cdman
Copy link

cdman commented Jun 8, 2011

Hello.

The spec file (jzmq.spec) invokes make with smp flags on multi-code machines:

%{__make} %{?_smp_mflags}

However this doesn't work on actual multi-code machines (tested with Centos 5.6 on a VM which had 4 CPUs allocated to it) because of some weird dependency issue in the order of compiling. Rather than debugging (lazyness is a virtue ;-)), just getting rid of the smp flags solves the problem. I propose to change the spec file to this:

%{__make}

This solves the issue and there is not that much C++ code that needs to be compiled for this to be an issue.

Best regards,
Attila Balazs

@gonzus
Copy link
Contributor

gonzus commented Jun 28, 2011

Can you please provide a patch / pull request? Thanks.

@gui81
Copy link
Contributor

gui81 commented Sep 15, 2011

I did not see this issue, but have fixed it in pull request #71, which has already been merged. cdman is right, that we could debug the issue, but compiling takes very little time, so I just removed the smp_mflags option. This was necessary when building to create an RPM, which was what my fix addressed.

@gonzus
Copy link
Contributor

gonzus commented Sep 15, 2011

In that case: cdman, could you close this issue?

@cdman
Copy link
Author

cdman commented Sep 15, 2011

Done, thank you for fixing it.

@cdman cdman closed this as completed Sep 15, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants