Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: missing CLOEXEC flag on eventfd and epoll instances #2242

Closed
rtlfu opened this issue Dec 7, 2016 · 3 comments
Closed

Problem: missing CLOEXEC flag on eventfd and epoll instances #2242

rtlfu opened this issue Dec 7, 2016 · 3 comments

Comments

@rtlfu
Copy link

rtlfu commented Dec 7, 2016

on Linux, libzmq is leaking file descriptors when fork+exec for lack of CLOEXEC flag.

See
https://github.com/zeromq/libzmq/blob/master/src/epoll.cpp#L51
https://github.com/zeromq/libzmq/blob/master/src/signaler.cpp#L384

On other platforms, a possible candidate is
https://github.com/zeromq/libzmq/blob/master/src/signaler.cpp#L640

@bluca
Copy link
Member

bluca commented Dec 7, 2016

The flag is set for other sockets:
https://github.com/zeromq/libzmq/blob/master/src/ip.cpp#L51

So it sounds like the correct thing to set it for those too.
Would you be able to send a PR?

@rtlfu
Copy link
Author

rtlfu commented Dec 7, 2016

I have yet to figure out how to do a PR?!

@rtlfu rtlfu closed this as completed Dec 7, 2016
@bluca
Copy link
Member

bluca commented Dec 7, 2016

Do you need some tips on how to set everything up? Github's documentation should be a good starting point

@bluca bluca reopened this Dec 26, 2016
@bluca bluca changed the title missing CLOEXEC flag on eventfd and epoll instances Problem: missing CLOEXEC flag on eventfd and epoll instances Dec 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants