New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

endpoint.hpp throws a compiler warning due to `const bool` return #4629

Closed

nehalkpatel opened this issue Nov 19, 2023 · 0 comments · Fixed by #4630

Contributor

nehalkpatel commented Nov 19, 2023 •

edited

https://github.com/zeromq/libzmq/blame/814dab58a4eea3202d28d7db4fa24c27287c5378/src/endpoint.hpp#L32

Since bool is returned by value, the const is redundant and will throw an ignored-qualifier warning with clang:

[build] build/host/_deps/zeromq-src/src/endpoint.hpp:32:5: warning: 'const' type qualifier on return type has no effect [-Wignored-qualifiers]
[build]    32 |     const bool clash () const { return local == remote; }
[build]       |     ^~~~~

The text was updated successfully, but these errors were encountered:

bluca linked a pull request

that will close this issue

Fix 4629 compile warning in endpoint.hpp #4630

Merged

bluca closed this as completed in #4630

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment