NetMQPoller Refuses to Stop - Bug?

[peske]

Environment

NetMQ Version:    4.0.0-rc5
Operating System: Win 10 x64
.NET Version:     4.6.1

Expected behaviour

NetMQPoller should stop when Stop method is called.

Actual behaviour

NetMQPoller does not stop on Stop method call.

Steps to reproduce the behaviour

I'll provide code snippet:

class MyClass : IDisposable {
    private readonly NetMQPoller _poller = new NetMQPoller();
    private readonly NetMQTimer _pollTimeout = new NetMQTimer(TimeSpan.FromMilliseconds(50));
    private readonly PairSocket _subReceiver = new PairSocket();
    private readonly DealerSocket _receiver = new DealerSocket();

    MyClass() {
        _subReceiver.Bind("inproc://someaddress");
        _receiver.Connect("tcp://otheraddress");

        _receiver.ReceiveReady += Socket_ReceiveReady;
        _subReceiver.ReceiveReady += SubReceiver_ReceiveReady;
        _pollTimeout.Elapsed += PollTimeout_Elapsed;

        _poller.Add(_pollTimeout);
        _poller.Add(_receiver);
        _poller.Add(_subReceiver);
    }

    void Socket_ReceiveReady(object sender, NetMQSocketEventArgs e) {
       _poller.Stop();
    }

    void SubReceiver_ReceiveReady(object sender, NetMQSocketEventArgs e) {
        // Never happens!
       _poller.Stop();
    }

    void PollTimeout_Elapsed(object sender, NetMQTimerEventArgs e) {
        _poller.Stop();
    }

    void Iteration() {
        _pollTimeout.Interval = 50;
        _pollTimeout.EnableAndReset();

        _poller.Run();
    }

    void Dispose() {
        //...
    }
}

Method Iteration() is called by external code within the loop (the same thread).

There are several problems with this:

1. SubReceiver_ReceiveReady is never called (ReceiveReady is never triggered) although messages are arriving to _subReceiver (PairSocket). I'm positive that messages are arriving because I'm able to receive them "manually" from within Iteration method body.
2. _poller.Stop() successfully stops the poller few times (2-3), but after that not. What is happening after that is that PollTimeout_Elapsed gets called regularly, every time calling _poller.Stop(), but poller never gets stopped. (I've placed break points into all the methods and realized that only PollTimeout_Elapsed has any activity.)

Am I doing something wrong? Or it is a bug?

Thanks

[peske]

Guyz, have you checked this? Is there a problem in my code?

Thanks!

[somdoron]

It seems the poller is not very good at stopping and starting, I will ckeck it out

[peske]

Doron, any news about this? Actually the thing that concerns me more than inability to stop the poller is the fact that SubReceiver_ReceiveReady is never called, meaning that ReceiveReady is never triggered. If it is true, it is huge - show-stopper bug in core functionality.

Meanwhile, if you have a few seconds I would appreciate if you take a look at zeromq/libzmq#2078 - it might happen that you can help in sentence or two...
(I've solved referenced issue meanwhile.)

Thanks

[somdoron]

@peske the problem is you have to readd the sockets after each run of the poller, apparently the poller is removing all sockets after every run, we should probably fix this

[somdoron]

@peske I'm exposing the internal class NetMQPoller is using to do the polling, the internal class API is exactly like the zmq_poll

[somdoron]

@peske take a look at the following Pull Request:

#599

You can now use NetMQSelector, behavior exactly like zmq_poll

[peske]

Thanks Doron! I'll give a shot and let you know.

[stale]

This issue has been automatically marked as stale because it has not had activity for 365 days. It will be closed if no further activity occurs within 56 days. Thank you for your contributions.