MSWin32 compatibility and test portability #47

zmughal · 2021-11-29T01:13:58Z

This PR replaces #44.

Add generic CI workflow
MSWin32 compatibility
Use platform-specific endpoints for testing connections

zmughal · 2021-12-29T11:14:56Z

@calid, do you have a chance to look at this?

zmughal · 2022-02-01T00:46:53Z

Hi @calid, is there anything else you would like to see for this PR?

ghenry · 2022-02-08T11:48:53Z

Hi @zmughal

I'm helping maintain this now. Can you have a look at https://github.com/zeromq/perlzmq/runs/4348450971?check_suite_focus=true

Thanks.

zmughal · 2022-02-08T21:18:31Z

Hello @ghenry, thank you for taking a look.

That is due to my adding of another Dist::Zilla plugin (https://metacpan.org/pod/Dist::Zilla::Plugin::DynamicPrereqs so that Sys::SigAction is only a test requirement for non-MSWin32 systems). It requires pushing a new version of the calid/zmq-ffi-testenv:ubuntu Docker image so that all the authordeps are available.

What I can do in a commit is update that CI workflow to install the missing deps so that it passes, but at some point a new Docker image will need to be used.

calid · 2022-02-08T21:46:09Z

@ghenry scripts/docker-build and scripts/docker-push can help with building/updating the docker images (run once working directory is in the desired state)

ghenry · 2022-02-08T21:49:46Z

Thanks. I'll look to update the images tomorrow evening.

calid · 2022-02-08T21:51:29Z

sounds good, I can either add your docker id as a collaborator on the existing docker hub repos, or you can just change to your own, whichever you prefer

ghenry · 2022-02-08T21:55:22Z

Cool. Can you add sentrypeer user in as that's the only one I've set up on DH so far.

calid · 2022-02-08T21:58:22Z

added, let me know if any issues

ghenry · 2022-02-08T22:10:59Z

Sorry, let me keep that user clean. I have https://hub.docker.com/u/gavinhenry too. Could you swap when you get a sec?

Thanks.

calid · 2022-02-08T22:57:22Z

Sorry, let me keep that user clean. I have https://hub.docker.com/u/gavinhenry too. Could you swap when you get a sec?

Thanks.

Done!

zmughal · 2022-02-08T23:09:52Z

@ghenry, @calid, the PR should be ready now (fixed the authordeps and updated the recently merged tests for #46).

- Use standard ZMQ DLL name for MSWin32. - Add test helper library for determining platform capabilities for testing. - Only use test dependency `Sys::SigAction` on non-MSWin32. - Skip tests that use `fork(2)` on MSWin32. - Skip tests for `get_fd()` as this is currently only implemented for Unix-likes.

The `zmq_ipc(7)` protocol is implemented using Unix domain sockets (which are not available on MSWin32). On platforms with Unix domain sockets, use `ipc://` and use `inproc://` elsewhere.

ghenry · 2022-02-09T14:38:06Z

Updating Docker images now.

ghenry · 2022-02-09T14:39:28Z

What's the workflow for getting/setting a version for docker-build and docker-push scripts?

ghenry · 2022-02-16T17:31:58Z

Should get time for this tonight/tomorrow. Thanks for all the pointers!

ghenry · 2022-02-17T11:02:09Z

Yep! I usually did it from within the container using the release shell script in case something went sad, but I think the GitHub actions are running the full test harness and build/install so if that looks good probably safe to just straight up docker-run dzil release

Running this now:

TAG="1.18"; ./scripts/docker-build $TAG && ./scripts/docker-push $TAG

but I'm being dumb. What is docker-run ?

ghenry · 2022-02-17T11:21:52Z

Failure :-(

xisofs-1.3/install.pl
xisofs-1.3/HISTORY
xisofs-1.3/VERSION
xisofs-1.3/xisofs.pl
xisofs-1.3/Bubble.pm
Entering xisofs-1.3
META.yml/json not found. Creating skeleton for it.
! The distribution doesn't have a proper Makefile.PL/Build.PL See /root/.cpanm/work/1645096535.8/build.log for details.
Searching 255 () on cpanmetadb ...
! Finding 255 on cpanmetadb failed.
! Could not find a release matching 255 on MetaCPAN.
Searching 255 on mirror http://www.cpan.org ...
! Finding 255 () on mirror http://www.cpan.org failed.
! Couldn't find module or a distribution 255
Searching (65280) () on cpanmetadb ...
! Finding (65280) on cpanmetadb failed.
! Could not find a release matching (65280) on MetaCPAN.
Searching (65280) on mirror http://www.cpan.org ...
! Finding (65280) () on mirror http://www.cpan.org failed.
! Couldn't find module or a distribution (65280)
Configuring xisofs-1.3 ... N/A
The command '/bin/sh -c cd /zmq-ffi && dzil listdeps --missing | cpanm -v' returned a non-zero code: 1

calid · 2022-02-17T17:55:04Z

but I'm being dumb. What is docker-run ?

it's just a helper script at the top level of the repo

https://github.com/zeromq/perlzmq/blob/master/docker-run

there's also docker-shell

https://github.com/zeromq/perlzmq/blob/master/docker-shell

calid · 2022-02-17T18:12:36Z

Failure :-(
...
! Finding 255 on cpanmetadb failed.

This looks like something is misconfigured or typo'd somewhere... I would maybe checkout before the recent PR's and try a build to confirm if it's something in the recent changes

ghenry · 2022-02-17T19:38:20Z

Idiot! I should have spotted that. Will try again. Thanks.

ghenry · 2022-02-17T20:34:37Z

Everything is failing due to Dist::Zilla::Plugin::DynamicPrereqs not being installed for whats in dist.ini

What's the best way to add this? Inside Dockerfile via cpanm?

calid · 2022-02-17T21:32:14Z

Everything is failing due to Dist::Zilla::Plugin::DynamicPrereqs not being installed for whats in dist.ini

What's the best way to add this? Inside Dockerfile via cpanm?

yeah, fire up a shell inside the docker container (docker-shell helper), fixup dependencies as you would normally using standard commands, get everything in a happy state, and then cut/publish an image once things look good.

And in case it wasn't obvious, the only difference between the docker-shell and docker-release-shell helpers is the release shell bind mounts .ssh and other directories needed for push permissions... hence I wouldn't use it when creating vanilla images for any contributor to use, and just for doing an actual release

ghenry · 2022-02-17T23:13:13Z

Cool, thanks. Will do in the morning.

ghenry · 2022-02-23T09:56:33Z

Sorry about the delay. I did get a shell on this image and install the dep, but still failing to build. Will dig in more.

zmughal · 2022-03-07T02:55:04Z

@ghenry, is there anything I can do to help? I have put together a PR at #49 that should allow for creating a new Docker image using ./scripts/docker-build.

ghenry · 2022-03-07T07:17:52Z

Cool. Thanks. I'll check it out today.

zmughal · 2022-03-18T19:14:48Z

Hello @ghenry, were you able to make some progress on this release?

I would like to use it to switch the dependencies of Devel::IPerl from ZMQ::LibZMQ3 to ZMQ::FFI. Let me know if there are any blockers and I can investigate.

ghenry · 2022-03-18T19:51:09Z

A MetaCPAN release?

zmughal · 2022-03-18T20:39:47Z

Yes, an upload to CPAN. Should be just (from a clean checkout):

Update Docker:

./scripts/docker-build 1.18 && ./scripts/docker-push 1.18

Run release shell:

./scripts/docker-release-shell

and inside the release shell, run:

dzil build && cpanm --installdeps ./ZMQ-FFI-1.18.tar.gz && dzil release

Also, if you get a chance, could you review #50?

ghenry · 2022-03-18T21:26:07Z

Running now.

ghenry · 2022-03-18T21:39:49Z

Docker Hub updated! Whoot Whoot!!!!

ghenry · 2022-03-18T21:43:40Z

Last step I get:

zmughal · 2022-03-18T22:15:15Z

Ah, that happens when you do not have a .gitconfig. An empty file should be fine.

Run this outside the Docker

touch ~/.gitconfig

and then re-run the Docker release shell.

zmughal · 2022-03-18T22:18:37Z

Actually, better than empty one would be one with your author and e-mail info: https://www.git-scm.com/book/en/v2/Customizing-Git-Git-Configuration.

zmughal · 2022-03-18T22:28:31Z

Make sure all of these exist on the host: https://github.com/zeromq/perlzmq/blob/master/scripts/docker-release-shell

.ssh directory (to push to GitHub)
.pause file (to upload to CPAN)
.gitconfig file (to configure git when it runs / commits)
.gitignore file (this is not necessary afaict)

zmughal · 2022-03-21T02:11:15Z

@ghenry, did setting up the dotfiles work on your end?

ghenry · 2022-03-21T07:18:48Z

Trying again today.

ghenry · 2022-03-21T10:49:38Z

Running better now. Issue was I had to us "sudo" so it was looking for all those files in /root/.* not my normal user.

ghenry · 2022-03-21T10:52:51Z

Cool. Just sorting my PAT for GitHub: https://metacpan.org/release/GHENRY/ZMQ-FFI-1.18

ghenry · 2022-03-21T10:59:19Z

Sorted the git push now. All ready for next time now! Thanks for your prompts and patience Zaki. Much appreciated.

zmughal · 2022-03-21T15:24:50Z

Excellent! Thank you!

zmughal · 2022-03-21T15:58:45Z

You might want to also do:

git push --tags

because I don't see a tag for 1.18 yet https://github.com/zeromq/perlzmq/tags.

ghenry · 2022-03-21T16:06:16Z

Done. Oops.

zmughal force-pushed the mswin32-compat branch from 11d7627 to 7d5a914 Compare November 29, 2021 01:28

zmughal force-pushed the mswin32-compat branch 3 times, most recently from 9286f4c to b9cf0f7 Compare February 8, 2022 22:03

zmughal force-pushed the mswin32-compat branch 4 times, most recently from 4a3c1f8 to a4f595c Compare February 8, 2022 22:51

zmughal force-pushed the mswin32-compat branch from a4f595c to 8ee1efe Compare February 8, 2022 23:26

zmughal added 4 commits February 8, 2022 18:51

Add generic CI workflow

e0cff0f

Use platform-specific endpoints for testing connections

192ee7b

The `zmq_ipc(7)` protocol is implemented using Unix domain sockets (which are not available on MSWin32). On platforms with Unix domain sockets, use `ipc://` and use `inproc://` elsewhere.

GHA: Update dzil authordeps in docker-test

96cc5f5

zmughal force-pushed the mswin32-compat branch from 8ee1efe to 96cc5f5 Compare February 8, 2022 23:51

ghenry merged commit ce5dc26 into zeromq:master Feb 9, 2022

zmughal deleted the mswin32-compat branch February 9, 2022 16:05

ghenry mentioned this pull request Aug 4, 2023

Perl 5.38.0 deprecates when keyword #52

Merged

MSWin32 compatibility and test portability #47

MSWin32 compatibility and test portability #47

Conversation

zmughal commented Nov 29, 2021 • edited

zmughal commented Dec 29, 2021

zmughal commented Feb 1, 2022

ghenry commented Feb 8, 2022

zmughal commented Feb 8, 2022

calid commented Feb 8, 2022

ghenry commented Feb 8, 2022

calid commented Feb 8, 2022

ghenry commented Feb 8, 2022

calid commented Feb 8, 2022

ghenry commented Feb 8, 2022

calid commented Feb 8, 2022

zmughal commented Feb 8, 2022

ghenry commented Feb 9, 2022

ghenry commented Feb 9, 2022

ghenry commented Feb 16, 2022

ghenry commented Feb 17, 2022

ghenry commented Feb 17, 2022

calid commented Feb 17, 2022

calid commented Feb 17, 2022

ghenry commented Feb 17, 2022

ghenry commented Feb 17, 2022

calid commented Feb 17, 2022

ghenry commented Feb 17, 2022 via email

ghenry commented Feb 23, 2022

zmughal commented Mar 7, 2022

ghenry commented Mar 7, 2022

zmughal commented Mar 18, 2022

ghenry commented Mar 18, 2022

zmughal commented Mar 18, 2022

ghenry commented Mar 18, 2022 via email

ghenry commented Mar 18, 2022 via email

ghenry commented Mar 18, 2022

zmughal commented Mar 18, 2022

zmughal commented Mar 18, 2022

zmughal commented Mar 18, 2022

zmughal commented Mar 21, 2022

ghenry commented Mar 21, 2022

ghenry commented Mar 21, 2022 via email

ghenry commented Mar 21, 2022 via email

ghenry commented Mar 21, 2022 via email

zmughal commented Mar 21, 2022

zmughal commented Mar 21, 2022

ghenry commented Mar 21, 2022 via email

zmughal commented Nov 29, 2021 •

edited