Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input decoration theme UI is not working #166

Closed
suv12345 opened this issue Dec 6, 2021 · 4 comments
Closed

Input decoration theme UI is not working #166

suv12345 opened this issue Dec 6, 2021 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@suv12345
Copy link

suv12345 commented Dec 6, 2021

Platform

Web

Steps To Reproduce

  1. Open link https://zeshuaro.github.io/flutter_theme/#/
  2. Go to advanced tab
  3. Change input decoration theme UI

Expected Behavior
All reflected both in theme config UI as well as preview UI

Actual behavior

Nothing got reflected and no impact on changed theme in preview UI of inputs

@suv12345 suv12345 added the bug Something isn't working label Dec 6, 2021
@zeshuaro
Copy link
Owner

zeshuaro commented Dec 6, 2021

@suvdev123 Thanks for reporting the issue. Would you mind to clarify which options for input decoration are not being reflected on the UI?

Note that for input decoration, all the colour options have no effects unless the option Filled is turned on.

@zeshuaro zeshuaro self-assigned this Dec 6, 2021
@suv12345
Copy link
Author

suv12345 commented Dec 6, 2021

Filled is turned on.

Ok, There was a misunderstanding about this . what about Focus Color of input decoration theme.

@zeshuaro
Copy link
Owner

zeshuaro commented Dec 6, 2021

Turns out focusColor doesn't seem to be used anymore in InputDecoration. See flutter/flutter#50866.

I'll probably raise a PR to remove this in Flutter Theme to avoid confusions.

@suv12345
Copy link
Author

suv12345 commented Dec 6, 2021

ok ,I am closing this issue. Thank you very much for your quick response.

@suv12345 suv12345 closed this as completed Dec 6, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants