Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Advanced theme export does not output correct ColorScheme #335

Closed
kirinnee opened this issue Mar 10, 2022 · 3 comments · Fixed by #336
Closed

[BUG] Advanced theme export does not output correct ColorScheme #335

kirinnee opened this issue Mar 10, 2022 · 3 comments · Fixed by #336
Assignees
@zeshuaro
Labels
bug Something isn't working

Comments

@kirinnee
Copy link

Platform

Web

Steps to Reproduce

  1. Go to appainter.dev
  2. Go to advance and edit
  3. Press export

Expected behaviour

Export advanced configured theme as appainter_theme.json

Actual behaviour

export basic theme

Additional Context

No context
@kirinnee kirinnee added the bug Something isn't working label Mar 10, 2022
@zeshuaro
Copy link
Owner

Hey @kirinnee, thanks for raising this issue.

Would you be able share more information on this? I tested this just then and didn't see any issues. So I'm curious on how did you determine that the advanced configuration was not exported?

@zeshuaro zeshuaro self-assigned this Mar 11, 2022
@kirinnee
Copy link
Author

kirinnee commented Mar 11, 2022 •
edited

hey @zeshuaro , thanks for the quick reply!

The colorScheme fields are not updated if:

  1. Open the site
  2. Click on Advanced
  3. Change primary color.

The colorScheme field will still use ff2196f3 as primary and secondary color.

This applies even if you import.

Also, not sure if it is intended, but additional configurations, such as AppBar configurtaion/Button configuration are only added if I manually change them.

theme.json:

{
  "applyElevationOverlayColor": false,
  "backgroundColor": "#fff06292",
  "bottomAppBarColor": "#ffffffff",
  "brightness": "light",
  "buttonTheme": {
    "alignedDropdown": false,
    "colorScheme": {
      "background": "#fff06292",
      "brightness": "light",
      "error": "#ffd32f2f",
      "errorContainer": "#ffd32f2f",
      "inversePrimary": "#ffffffff",
      "inverseSurface": "#ff000000",
      "onBackground": "#ffffffff",
      "onError": "#ffffffff",
      "onErrorContainer": "#ffffffff",
      "onInverseSurface": "#ffffffff",
      "onPrimary": "#ffffffff",
      "onPrimaryContainer": "#ffffffff",
      "onSecondary": "#ffffffff",
      "onSecondaryContainer": "#ffffffff",
      "onSurface": "#ff000000",
      "onSurfaceVariant": "#ff000000",
      "onTertiary": "#ffffffff",
      "onTertiaryContainer": "#ffffffff",
      "outline": "#ffffffff",
      "primary": "#ff2196f3",
      "primaryContainer": "#ff2196f3",
      "secondary": "#ff2196f3",
      "secondaryContainer": "#ff2196f3",
      "shadow": "#ffffffff",
      "surface": "#ffffffff",
      "tertiary": "#ff2196f3",
      "tertiaryContainer": "#ff2196f3"
    },
    "height": 36,
    "layoutBehavior": "padded",
    "minWidth": 88,
    "padding": {
      "bottom": 0,
      "left": 16,
      "right": 16,
      "top": 0
    },
    "shape": {
      "borderRadius": {
        "bottomLeft": {
          "type": "elliptical",
          "x": 2,
          "y": 2
        },
        "bottomRight": {
          "type": "elliptical",
          "x": 2,
          "y": 2
        },
        "topLeft": {
          "type": "elliptical",
          "x": 2,
          "y": 2
        },
        "topRight": {
          "type": "elliptical",
          "x": 2,
          "y": 2
        },
        "type": "only"
      },
      "side": {
        "color": "#ff000000",
        "style": "none",
        "width": 0
      },
      "type": "rounded"
    },
    "textTheme": "normal"
  },
  "canvasColor": "#fffafafa",
  "cardColor": "#ffffffff",
  "colorScheme": {
    "background": "#fff06292",
    "brightness": "light",
    "error": "#ffd32f2f",
    "errorContainer": "#ffd32f2f",
    "inversePrimary": "#ffffffff",
    "inverseSurface": "#ff000000",
    "onBackground": "#ffffffff",
    "onError": "#ffffffff",
    "onErrorContainer": "#ffffffff",
    "onInverseSurface": "#ffffffff",
    "onPrimary": "#ffffffff",
    "onPrimaryContainer": "#ffffffff",
    "onSecondary": "#ffffffff",
    "onSecondaryContainer": "#ffffffff",
    "onSurface": "#ff000000",
    "onSurfaceVariant": "#ff000000",
    "onTertiary": "#ffffffff",
    "onTertiaryContainer": "#ffffffff",
    "outline": "#ffffffff",
    "primary": "#ff2196f3",
    "primaryContainer": "#ff2196f3",
    "secondary": "#ff2196f3",
    "secondaryContainer": "#ff2196f3",
    "shadow": "#ffffffff",
    "surface": "#ffffffff",
    "tertiary": "#ff2196f3",
    "tertiaryContainer": "#ff2196f3"
  },
  "dialogBackgroundColor": "#ffffffff",
  "disabledColor": "#61000000",
  "dividerColor": "#1f000000",
  "errorColor": "#ffd32f2f",
  "focusColor": "#1f000000",
  "highlightColor": "#66bcbcbc",
  "hintColor": "#99000000",
  "hoverColor": "#0a000000",
  "indicatorColor": "#ffe91e63",
  "inputDecorationTheme": {
    "alignLabelWithHint": false,
    "filled": false,
    "floatingLabelAlignment": "start",
    "floatingLabelBehavior": "auto",
    "isCollapsed": false,
    "isDense": false
  },
  "materialTapTargetSize": "shrinkWrap",
  "platform": "windows",
  "primaryColor": "#ffe91e63",
  "primaryColorDark": "#ffba184f",
  "primaryColorLight": "#fff278a1",
  "primaryIconTheme": {
    "color": "#ffffffff"
  },
  "primaryTextTheme": {
    "bodyLarge": {
      "color": "#ffffffff",
      "decoration": "none",
      "fontFamily": "Segoe UI",
      "inherit": true
    },
    "bodyMedium": {
      "color": "#ffffffff",
      "decoration": "none",
      "fontFamily": "Segoe UI",
      "inherit": true
    },
    "bodySmall": {
      "color": "#b3ffffff",
      "decoration": "none",
      "fontFamily": "Segoe UI",
      "inherit": true
    },
    "displayLarge": {
      "color": "#b3ffffff",
      "decoration": "none",
      "fontFamily": "Segoe UI",
      "inherit": true
    },
    "displayMedium": {
      "color": "#b3ffffff",
      "decoration": "none",
      "fontFamily": "Segoe UI",
      "inherit": true
    },
    "displaySmall": {
      "color": "#b3ffffff",
      "decoration": "none",
      "fontFamily": "Segoe UI",
      "inherit": true
    },
    "headlineLarge": {
      "color": "#b3ffffff",
      "decoration": "none",
      "fontFamily": "Segoe UI",
      "inherit": true
    },
    "headlineMedium": {
      "color": "#b3ffffff",
      "decoration": "none",
      "fontFamily": "Segoe UI",
      "inherit": true
    },
    "headlineSmall": {
      "color": "#ffffffff",
      "decoration": "none",
      "fontFamily": "Segoe UI",
      "inherit": true
    },
    "labelLarge": {
      "color": "#ffffffff",
      "decoration": "none",
      "fontFamily": "Segoe UI",
      "inherit": true
    },
    "labelMedium": {
      "color": "#ffffffff",
      "decoration": "none",
      "fontFamily": "Segoe UI",
      "inherit": true
    },
    "labelSmall": {
      "color": "#ffffffff",
      "decoration": "none",
      "fontFamily": "Segoe UI",
      "inherit": true
    },
    "titleLarge": {
      "color": "#ffffffff",
      "decoration": "none",
      "fontFamily": "Segoe UI",
      "inherit": true
    },
    "titleMedium": {
      "color": "#ffffffff",
      "decoration": "none",
      "fontFamily": "Segoe UI",
      "inherit": true
    },
    "titleSmall": {
      "color": "#ffffffff",
      "decoration": "none",
      "fontFamily": "Segoe UI",
      "inherit": true
    }
  },
  "scaffoldBackgroundColor": "#fffafafa",
  "secondaryHeaderColor": "#fff383a9",
  "selectedRowColor": "#fff5f5f5",
  "shadowColor": "#ff000000",
  "splashColor": "#66c8c8c8",
  "splashFactory": "splash",
  "textTheme": {
    "bodyLarge": {
      "color": "#dd000000",
      "decoration": "none",
      "fontFamily": "Roboto_regular",
      "fontFamilyFallback": [
        "Roboto"
      ],
      "fontWeight": "w400",
      "fontSize": 16,
      "inherit": true,
      "letterSpacing": 0.5,
      "textBaseline": "alphabetic"
    },
    "bodyMedium": {
      "color": "#dd000000",
      "decoration": "none",
      "fontFamily": "Roboto_regular",
      "fontFamilyFallback": [
        "Roboto"
      ],
      "fontWeight": "w400",
      "fontSize": 14,
      "inherit": true,
      "letterSpacing": 0.25,
      "textBaseline": "alphabetic"
    },
    "bodySmall": {
      "color": "#8a000000",
      "decoration": "none",
      "fontFamily": "Roboto_regular",
      "fontFamilyFallback": [
        "Roboto"
      ],
      "fontWeight": "w400",
      "fontSize": 12,
      "inherit": true,
      "letterSpacing": 0.4,
      "textBaseline": "alphabetic"
    },
    "displayLarge": {
      "color": "#8a000000",
      "decoration": "none",
      "fontFamily": "Roboto_300",
      "fontFamilyFallback": [
        "Roboto"
      ],
      "fontWeight": "w300",
      "fontSize": 96,
      "inherit": true,
      "letterSpacing": -1.5,
      "textBaseline": "alphabetic"
    },
    "displayMedium": {
      "color": "#8a000000",
      "decoration": "none",
      "fontFamily": "Roboto_300",
      "fontFamilyFallback": [
        "Roboto"
      ],
      "fontWeight": "w300",
      "fontSize": 60,
      "inherit": true,
      "letterSpacing": -0.5,
      "textBaseline": "alphabetic"
    },
    "displaySmall": {
      "color": "#8a000000",
      "decoration": "none",
      "fontFamily": "Roboto_regular",
      "fontFamilyFallback": [
        "Roboto"
      ],
      "fontWeight": "w400",
      "fontSize": 48,
      "inherit": true,
      "letterSpacing": 0,
      "textBaseline": "alphabetic"
    },
    "headlineLarge": {
      "color": "#8a000000",
      "decoration": "none",
      "fontFamily": "Roboto_regular",
      "fontFamilyFallback": [
        "Roboto"
      ],
      "inherit": true
    },
    "headlineMedium": {
      "color": "#8a000000",
      "decoration": "none",
      "fontFamily": "Roboto_regular",
      "fontFamilyFallback": [
        "Roboto"
      ],
      "fontWeight": "w400",
      "fontSize": 34,
      "inherit": true,
      "letterSpacing": 0.25,
      "textBaseline": "alphabetic"
    },
    "headlineSmall": {
      "color": "#dd000000",
      "decoration": "none",
      "fontFamily": "Roboto_regular",
      "fontFamilyFallback": [
        "Roboto"
      ],
      "fontWeight": "w400",
      "fontSize": 24,
      "inherit": true,
      "letterSpacing": 0,
      "textBaseline": "alphabetic"
    },
    "labelLarge": {
      "color": "#dd000000",
      "decoration": "none",
      "fontFamily": "Roboto_500",
      "fontFamilyFallback": [
        "Roboto"
      ],
      "fontWeight": "w500",
      "fontSize": 14,
      "inherit": true,
      "letterSpacing": 1.25,
      "textBaseline": "alphabetic"
    },
    "labelMedium": {
      "color": "#ff000000",
      "decoration": "none",
      "fontFamily": "Roboto_regular",
      "fontFamilyFallback": [
        "Roboto"
      ],
      "inherit": true
    },
    "labelSmall": {
      "color": "#ff000000",
      "decoration": "none",
      "fontFamily": "Roboto_regular",
      "fontFamilyFallback": [
        "Roboto"
      ],
      "fontWeight": "w400",
      "fontSize": 10,
      "inherit": true,
      "letterSpacing": 1.5,
      "textBaseline": "alphabetic"
    },
    "titleLarge": {
      "color": "#dd000000",
      "decoration": "none",
      "fontFamily": "Roboto_500",
      "fontFamilyFallback": [
        "Roboto"
      ],
      "fontWeight": "w500",
      "fontSize": 20,
      "inherit": true,
      "letterSpacing": 0.15,
      "textBaseline": "alphabetic"
    },
    "titleMedium": {
      "color": "#dd000000",
      "decoration": "none",
      "fontFamily": "Roboto_regular",
      "fontFamilyFallback": [
        "Roboto"
      ],
      "fontWeight": "w400",
      "fontSize": 16,
      "inherit": true,
      "letterSpacing": 0.15,
      "textBaseline": "alphabetic"
    },
    "titleSmall": {
      "color": "#ff000000",
      "decoration": "none",
      "fontFamily": "Roboto_500",
      "fontFamilyFallback": [
        "Roboto"
      ],
      "fontWeight": "w500",
      "fontSize": 14,
      "inherit": true,
      "letterSpacing": 0.1,
      "textBaseline": "alphabetic"
    }
  },
  "toggleableActiveColor": "#ffd21b59",
  "typography": {
    "black": {
      "bodyLarge": {
        "color": "#dd000000",
        "decoration": "none",
        "fontFamily": "Segoe UI",
        "inherit": true
      },
      "bodyMedium": {
        "color": "#dd000000",
        "decoration": "none",
        "fontFamily": "Segoe UI",
        "inherit": true
      },
      "bodySmall": {
        "color": "#8a000000",
        "decoration": "none",
        "fontFamily": "Segoe UI",
        "inherit": true
      },
      "displayLarge": {
        "color": "#8a000000",
        "decoration": "none",
        "fontFamily": "Segoe UI",
        "inherit": true
      },
      "displayMedium": {
        "color": "#8a000000",
        "decoration": "none",
        "fontFamily": "Segoe UI",
        "inherit": true
      },
      "displaySmall": {
        "color": "#8a000000",
        "decoration": "none",
        "fontFamily": "Segoe UI",
        "inherit": true
      },
      "headlineLarge": {
        "color": "#8a000000",
        "decoration": "none",
        "fontFamily": "Segoe UI",
        "inherit": true
      },
      "headlineMedium": {
        "color": "#8a000000",
        "decoration": "none",
        "fontFamily": "Segoe UI",
        "inherit": true
      },
      "headlineSmall": {
        "color": "#dd000000",
        "decoration": "none",
        "fontFamily": "Segoe UI",
        "inherit": true
      },
      "labelLarge": {
        "color": "#dd000000",
        "decoration": "none",
        "fontFamily": "Segoe UI",
        "inherit": true
      },
      "labelMedium": {
        "color": "#ff000000",
        "decoration": "none",
        "fontFamily": "Segoe UI",
        "inherit": true
      },
      "labelSmall": {
        "color": "#ff000000",
        "decoration": "none",
        "fontFamily": "Segoe UI",
        "inherit": true
      },
      "titleLarge": {
        "color": "#dd000000",
        "decoration": "none",
        "fontFamily": "Segoe UI",
        "inherit": true
      },
      "titleMedium": {
        "color": "#dd000000",
        "decoration": "none",
        "fontFamily": "Segoe UI",
        "inherit": true
      },
      "titleSmall": {
        "color": "#ff000000",
        "decoration": "none",
        "fontFamily": "Segoe UI",
        "inherit": true
      }
    },
    "dense": {
      "bodyLarge": {
        "fontWeight": "w500",
        "fontSize": 15,
        "inherit": false,
        "textBaseline": "ideographic"
      },
      "bodyMedium": {
        "fontWeight": "w400",
        "fontSize": 15,
        "inherit": false,
        "textBaseline": "ideographic"
      },
      "bodySmall": {
        "fontWeight": "w400",
        "fontSize": 13,
        "inherit": false,
        "textBaseline": "ideographic"
      },
      "displayLarge": {
        "fontWeight": "w100",
        "fontSize": 112,
        "inherit": false,
        "textBaseline": "ideographic"
      },
      "displayMedium": {
        "fontWeight": "w400",
        "fontSize": 56,
        "inherit": false,
        "textBaseline": "ideographic"
      },
      "displaySmall": {
        "fontWeight": "w400",
        "fontSize": 45,
        "inherit": false,
        "textBaseline": "ideographic"
      },
      "headlineLarge": {
        "fontWeight": "w400",
        "fontSize": 40,
        "inherit": false,
        "textBaseline": "ideographic"
      },
      "headlineMedium": {
        "fontWeight": "w400",
        "fontSize": 34,
        "inherit": false,
        "textBaseline": "ideographic"
      },
      "headlineSmall": {
        "fontWeight": "w400",
        "fontSize": 24,
        "inherit": false,
        "textBaseline": "ideographic"
      },
      "labelLarge": {
        "fontWeight": "w500",
        "fontSize": 15,
        "inherit": false,
        "textBaseline": "ideographic"
      },
      "labelMedium": {
        "fontWeight": "w400",
        "fontSize": 12,
        "inherit": false,
        "textBaseline": "ideographic"
      },
      "labelSmall": {
        "fontWeight": "w400",
        "fontSize": 11,
        "inherit": false,
        "textBaseline": "ideographic"
      },
      "titleLarge": {
        "fontWeight": "w500",
        "fontSize": 21,
        "inherit": false,
        "textBaseline": "ideographic"
      },
      "titleMedium": {
        "fontWeight": "w400",
        "fontSize": 17,
        "inherit": false,
        "textBaseline": "ideographic"
      },
      "titleSmall": {
        "fontWeight": "w500",
        "fontSize": 15,
        "inherit": false,
        "textBaseline": "ideographic"
      }
    },
    "englishLike": {
      "bodyLarge": {
        "fontWeight": "w500",
        "fontSize": 14,
        "inherit": false,
        "textBaseline": "alphabetic"
      },
      "bodyMedium": {
        "fontWeight": "w400",
        "fontSize": 14,
        "inherit": false,
        "textBaseline": "alphabetic"
      },
      "bodySmall": {
        "fontWeight": "w400",
        "fontSize": 12,
        "inherit": false,
        "textBaseline": "alphabetic"
      },
      "displayLarge": {
        "fontWeight": "w100",
        "fontSize": 112,
        "inherit": false,
        "textBaseline": "alphabetic"
      },
      "displayMedium": {
        "fontWeight": "w400",
        "fontSize": 56,
        "inherit": false,
        "textBaseline": "alphabetic"
      },
      "displaySmall": {
        "fontWeight": "w400",
        "fontSize": 45,
        "inherit": false,
        "textBaseline": "alphabetic"
      },
      "headlineLarge": {
        "fontWeight": "w400",
        "fontSize": 40,
        "inherit": false,
        "textBaseline": "alphabetic"
      },
      "headlineMedium": {
        "fontWeight": "w400",
        "fontSize": 34,
        "inherit": false,
        "textBaseline": "alphabetic"
      },
      "headlineSmall": {
        "fontWeight": "w400",
        "fontSize": 24,
        "inherit": false,
        "textBaseline": "alphabetic"
      },
      "labelLarge": {
        "fontWeight": "w500",
        "fontSize": 14,
        "inherit": false,
        "textBaseline": "alphabetic"
      },
      "labelMedium": {
        "fontWeight": "w400",
        "fontSize": 12,
        "inherit": false,
        "textBaseline": "alphabetic"
      },
      "labelSmall": {
        "fontWeight": "w400",
        "fontSize": 10,
        "inherit": false,
        "letterSpacing": 1.5,
        "textBaseline": "alphabetic"
      },
      "titleLarge": {
        "fontWeight": "w500",
        "fontSize": 20,
        "inherit": false,
        "textBaseline": "alphabetic"
      },
      "titleMedium": {
        "fontWeight": "w400",
        "fontSize": 16,
        "inherit": false,
        "textBaseline": "alphabetic"
      },
      "titleSmall": {
        "fontWeight": "w500",
        "fontSize": 14,
        "inherit": false,
        "letterSpacing": 0.1,
        "textBaseline": "alphabetic"
      }
    },
    "tall": {
      "bodyLarge": {
        "fontWeight": "w700",
        "fontSize": 15,
        "inherit": false,
        "textBaseline": "alphabetic"
      },
      "bodyMedium": {
        "fontWeight": "w400",
        "fontSize": 15,
        "inherit": false,
        "textBaseline": "alphabetic"
      },
      "bodySmall": {
        "fontWeight": "w400",
        "fontSize": 13,
        "inherit": false,
        "textBaseline": "alphabetic"
      },
      "displayLarge": {
        "fontWeight": "w400",
        "fontSize": 112,
        "inherit": false,
        "textBaseline": "alphabetic"
      },
      "displayMedium": {
        "fontWeight": "w400",
        "fontSize": 56,
        "inherit": false,
        "textBaseline": "alphabetic"
      },
      "displaySmall": {
        "fontWeight": "w400",
        "fontSize": 45,
        "inherit": false,
        "textBaseline": "alphabetic"
      },
      "headlineLarge": {
        "fontWeight": "w400",
        "fontSize": 40,
        "inherit": false,
        "textBaseline": "alphabetic"
      },
      "headlineMedium": {
        "fontWeight": "w400",
        "fontSize": 34,
        "inherit": false,
        "textBaseline": "alphabetic"
      },
      "headlineSmall": {
        "fontWeight": "w400",
        "fontSize": 24,
        "inherit": false,
        "textBaseline": "alphabetic"
      },
      "labelLarge": {
        "fontWeight": "w700",
        "fontSize": 15,
        "inherit": false,
        "textBaseline": "alphabetic"
      },
      "labelMedium": {
        "fontWeight": "w400",
        "fontSize": 12,
        "inherit": false,
        "textBaseline": "alphabetic"
      },
      "labelSmall": {
        "fontWeight": "w400",
        "fontSize": 11,
        "inherit": false,
        "textBaseline": "alphabetic"
      },
      "titleLarge": {
        "fontWeight": "w700",
        "fontSize": 21,
        "inherit": false,
        "textBaseline": "alphabetic"
      },
      "titleMedium": {
        "fontWeight": "w400",
        "fontSize": 17,
        "inherit": false,
        "textBaseline": "alphabetic"
      },
      "titleSmall": {
        "fontWeight": "w500",
        "fontSize": 15,
        "inherit": false,
        "textBaseline": "alphabetic"
      }
    },
    "white": {
      "bodyLarge": {
        "color": "#ffffffff",
        "decoration": "none",
        "fontFamily": "Segoe UI",
        "inherit": true
      },
      "bodyMedium": {
        "color": "#ffffffff",
        "decoration": "none",
        "fontFamily": "Segoe UI",
        "inherit": true
      },
      "bodySmall": {
        "color": "#b3ffffff",
        "decoration": "none",
        "fontFamily": "Segoe UI",
        "inherit": true
      },
      "displayLarge": {
        "color": "#b3ffffff",
        "decoration": "none",
        "fontFamily": "Segoe UI",
        "inherit": true
      },
      "displayMedium": {
        "color": "#b3ffffff",
        "decoration": "none",
        "fontFamily": "Segoe UI",
        "inherit": true
      },
      "displaySmall": {
        "color": "#b3ffffff",
        "decoration": "none",
        "fontFamily": "Segoe UI",
        "inherit": true
      },
      "headlineLarge": {
        "color": "#b3ffffff",
        "decoration": "none",
        "fontFamily": "Segoe UI",
        "inherit": true
      },
      "headlineMedium": {
        "color": "#b3ffffff",
        "decoration": "none",
        "fontFamily": "Segoe UI",
        "inherit": true
      },
      "headlineSmall": {
        "color": "#ffffffff",
        "decoration": "none",
        "fontFamily": "Segoe UI",
        "inherit": true
      },
      "labelLarge": {
        "color": "#ffffffff",
        "decoration": "none",
        "fontFamily": "Segoe UI",
        "inherit": true
      },
      "labelMedium": {
        "color": "#ffffffff",
        "decoration": "none",
        "fontFamily": "Segoe UI",
        "inherit": true
      },
      "labelSmall": {
        "color": "#ffffffff",
        "decoration": "none",
        "fontFamily": "Segoe UI",
        "inherit": true
      },
      "titleLarge": {
        "color": "#ffffffff",
        "decoration": "none",
        "fontFamily": "Segoe UI",
        "inherit": true
      },
      "titleMedium": {
        "color": "#ffffffff",
        "decoration": "none",
        "fontFamily": "Segoe UI",
        "inherit": true
      },
      "titleSmall": {
        "color": "#ffffffff",
        "decoration": "none",
        "fontFamily": "Segoe UI",
        "inherit": true
      }
    }
  },
  "unselectedWidgetColor": "#8a000000",
  "useMaterial3": false,
  "visualDensity": "compact"
}

State of appainter when exporting:
image

@zeshuaro
Copy link
Owner

zeshuaro commented Mar 12, 2022 •
edited

The colorScheme field will still use ff2196f3 as primary and secondary color.

Thanks for pointing that out, I can see the same behaviour. I'll look into this.

Also, not sure if it is intended, but additional configurations, such as AppBar configurtaion/Button configuration are only added if I manually change them.

Yes this is the intended behaviour. Take the backgroundColor property in AppBar for example, if you look at their docs, this is how it resolves what color to use:

If null, then the AppBarTheme.backgroundColor is used. If that value is also null, then AppBar uses the overall theme's ColorScheme.primary if the overall theme's brightness is Brightness.light, and ColorScheme.surface if the overall theme's brightness is Brightness.dark.

And so if you didn't make any changes to the AppBarTheme, then the output file will not contain any configurations for it. And will fallback to how Flutter defaults to resolve its color, which is to use the color from ColorScheme. Hope this makes sense 🙂

@zeshuaro zeshuaro changed the title [BUG] Cannot export advanced [BUG] Advanced theme export does not output correct ColorScheme Mar 12, 2022
@zeshuaro zeshuaro mentioned this issue Mar 12, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@zeshuaro zeshuaro

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: advanced theme not exporting correct color scheme zeshuaro/appainter
2 participants
@zeshuaro @kirinnee