Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for linenostart #340

Closed
arobase-che opened this issue Jul 8, 2019 · 4 comments · Fixed by #402
Closed

Support for linenostart #340

arobase-che opened this issue Jul 8, 2019 · 4 comments · Fixed by #402
Labels
misc/help wanted This issue needs help type/request This is great to have

Comments

@arobase-che
Copy link
Contributor

Hi \o

linenostart was an option used in the previous markdown processor.

Should we implement it ? It's still referenced in the fixtures. Search for linenostart

And in the official MD guide (Rédiger sur ZdS)

To implement it we need to update remark to version 6. and modify the file rehype-line-numbers.js to add something like style: 'counter-reset: a X;' where X is based on the attribute meta (implemented in version 6 of remark).

💗

@vhf vhf added type/request This is great to have misc/help wanted This issue needs help labels Jul 12, 2019
@vhf
Copy link
Contributor

vhf commented Jul 12, 2019

👍

See:

@arobase-che do you want to work on upgrading remark? Anyone else? I probably won't have time but I'd be happy to help.

#307 (comment)

@artragis
Copy link
Member

artragis commented Feb 2, 2020

to be closed on release, no?

@LikaKavkasidze
Copy link
Member

I thought this too, but updating only fix for LaTeX.
But with the new version of remark, we are able to use a new syntax for parsing, so this will be fixed soon.

@arobase-che
Copy link
Contributor Author

Still have to write a some code on the side of rehype-line-number I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
misc/help wanted This issue needs help type/request This is great to have
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants