You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've seen you updated select to optionally accept a span in master. However with the way it is implemented right now, span must be defined on every enum path. I've used the following implementation quite successfully:
I think this would be acceptable. IIRC the span feature isn't yet in a release, so this wouldn't be a breaking change. If you want to open a PR, feel free!
I've seen you updated select to optionally accept a span in
master
. However with the way it is implemented right now,span
must be defined on every enum path. I've used the following implementation quite successfully:This way
span
can only be specified once:select!(|span| Token::Literal(s) => (span, Value::Literal(s)))
I think this also easier to read, but that's probably a matter of opinion. If you want I can create a PR
The text was updated successfully, but these errors were encountered: