Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content: One to One and One to Many Field: Do Not Show Items that are Not Saved or Published in the dropdown options #2487

Closed
Tracked by #2480
zcolah opened this issue Jan 29, 2024 · 3 comments · Fixed by #2521
Assignees
Labels
bug Something isn't working

Comments

@zcolah
Copy link

zcolah commented Jan 29, 2024

Describe the bug
Currently an item that has only been locally created and is not saved or published is appearing as an option in the one to one and one to many field dropdowns. This leads to a user being able to select it and create an item with it.

Solution
This should not happen. Instead an item should only appear in the dropdown if it is:

  • Saved
  • Saved and Published
  • Saved and Scheduled to Publish

See Loom for full explanation.
https://www.loom.com/share/bf7ce4fb5c9d435083243b19d9d8bbcf

Note: @gtllien has confirmed that this issue is replicable and is a bug:

Looks like a bug to me - items should not appear in the dropdown selection unless it's already created/saved

@zcolah zcolah added the bug Something isn't working label Jan 29, 2024
@zcolah zcolah changed the title Content: Do Not Show Items that are Not Saved or Published in the One to One and One to Many Dropdown Options Content: One to One and One to Many Field: Do Not Show Items that are Not Saved or Published in the dropdown options Jan 29, 2024
@zcolah zcolah mentioned this issue Jan 29, 2024
13 tasks
@jomarmontuya jomarmontuya self-assigned this Jan 29, 2024
@jomarmontuya
Copy link
Contributor

jomarmontuya commented Feb 1, 2024

@zcolah @agalin920

Hello both just wanted to confirm if this behavior is intented. that we save the content item in the itemList even it was not created in the first place?

Screen.Recording.2024-02-01.at.7.15.00.PM.mov

if that was intented maybe we should just exclude this items with tag new-{itemzuid} from the dropdown list? to avoid showing up

Image

@zcolah
Copy link
Author

zcolah commented Feb 1, 2024

@jomarmontuya good question, I think @agalin920 can give more context on what the right approach is

@agalin920
Copy link
Contributor

@jomarmontuya

" if that was intented maybe we should just exclude this items with tag new-{itemzuid} from the dropdown list? to avoid showing up "

Is a valid approach as this is clear that the item has not been generated in the system and is only in local memory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants