Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content: Edit Content Item Page - Control P / Command P Shortcut to Publish Item does not work #2492

Open
Tracked by #2480 ...
zcolah opened this issue Jan 29, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@zcolah
Copy link

zcolah commented Jan 29, 2024

Bug

The following two functions defined the spec of the edit content item page are not working. Please fix them.

  1. A user should be able to save and publish an item if they use Control P or Command P | Figma
  2. A user should be able to publish an item if they use Control P or Command P | Figma

Reference Articles

https://www.robin-drexler.com/2015/07/07/overriding-default-browser-shortcuts/
https://support.mozilla.org/kn/questions/1367908#:~:text=You%20can%20use%20the%20Browser,want%20to%20disable%20or%20override.

@zcolah zcolah added the bug Something isn't working label Jan 29, 2024
@zcolah zcolah mentioned this issue Jan 29, 2024
13 tasks
@glespinosa
Copy link
Contributor

@zcolah I tried Ctrl+P without changing so far in the code it brings a modal isn't this the expected behavior?

screencast-8-aaeffee09b-7w6v22.manager.dev.zesty.io_8080-2024.02.06-18_23_30.webm

@glespinosa
Copy link
Contributor

@zcolah I think it's working fine also , I ask darwin to try it in their machine. Is cmd command working fine on your end?

@zcolah
Copy link
Author

zcolah commented Feb 15, 2024

@glespinosa it is now working. Closing this issue.

@zcolah zcolah closed this as completed Feb 15, 2024
@zcolah zcolah reopened this Apr 5, 2024
@zcolah
Copy link
Author

zcolah commented Apr 5, 2024

@glespinosa Command P is opening the print dialog. Can you look into why?
CleanShot 2024-04-05 at 21 30 24

@zcolah zcolah added this to Design Ready in Product Roadmap Apr 5, 2024
@glespinosa
Copy link
Contributor

@zcolah Upon checking I think because you're mouse is in focus on a textfield , I don't know if this issue existed previously. Try focusing it outside the textfield

@zcolah
Copy link
Author

zcolah commented Apr 8, 2024

@glespinosa
Could you then add an enhancement where the Command P and Control P shortcut works even if my house is focused on a text field, or is typing in an input?

@glespinosa
Copy link
Contributor

@zcolah upon checking again, while trying to reproduce the issue. It's now working fine.

screencast-8-aaeffee09b-7w6v22.manager.zesty.io-2024.04.08-23_00_33.webm

@zcolah zcolah mentioned this issue Apr 10, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Product Roadmap
Design Ready
Development

No branches or pull requests

2 participants