Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find a way to eliminate the 'voting on wrong ballot' problem (happened on Goerli) #1535

Closed
ws4charlie opened this issue Jan 8, 2024 · 2 comments · Fixed by #1570
Closed

Find a way to eliminate the 'voting on wrong ballot' problem (happened on Goerli) #1535

ws4charlie opened this issue Jan 8, 2024 · 2 comments · Fixed by #1570
Assignees
@ws4charlie
Milestone
v12-client

Comments

@ws4charlie
Copy link
Contributor

The receipt fetched from Goerli endpoint could contain wrong BlockNumber which lead to wrong ballots. We should find a reliable/way to avoid this in zetaclients at run time, instead of force restarting zetaclients to resume the voting.
@ws4charlie ws4charlie self-assigned this Jan 8, 2024
@ws4charlie ws4charlie mentioned this issue Jan 12, 2024
Merged
10 tasks
@lumtis lumtis added this to the v12-client milestone Jan 13, 2024
@kingpinXD
Copy link
Contributor

Hey, @ ws4charlie, can you link to some examples?
Are there different receipts for the same TX hash?

If there are garbage ballots , we can consider a cleanup function for ballots on zetacore which can run once every X number of blocks

@ws4charlie
Copy link
Contributor Author

Example of correct ballot: http://46.4.15.110:1317/zeta-chain/observer/ballot_by_identifier/0xef99263ce84e10b6edc6a4bc289f7689b87b73892f62f706b9a2138112d42865
Example of wrong ballot: http://46.4.15.110:1317/zeta-chain/observer/ballot_by_identifier/0x806f3e35635aaf886b076b693e2e7b82ad89eeb590d52201317d7845f4091fc5

Example txs that casted wrong ballot:
https://explorer.zetachain.com/cosmos/tx/88581E9895E5BEA02CA85F8B98C0CD8AB46393D6C4A86C1744BC765D299C83D2
https://explorer.zetachain.com/cosmos/tx/88581E9895E5BEA02CA85F8B98C0CD8AB46393D6C4A86C1744BC765D299C83D2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ws4charlie ws4charlie

Labels
None yet
Projects
None yet
Milestone
v12-client
Development

Successfully merging a pull request may close this issue.

fix: avoid voting on wrong ballots due to false blockNumber in EVM tx receipt zeta-chain/node
3 participants
@lumtis @kingpinXD @ws4charlie