New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bitcoin outbound tx gas fee calculation should be based on signed transaction size #1661

Closed

Tracked by

ws4charlie opened this issue Jan 29, 2024 · 0 comments · Fixed by #1669

Closed

Tracked by

Bitcoin outbound tx gas fee calculation should be based on signed transaction size #1661

ws4charlie opened this issue Jan 29, 2024 · 0 comments · Fixed by #1669

Assignees

Labels

zetaclient

Contributor

ws4charlie commented Jan 29, 2024

The current logic is using unsigned tx size to calculate gas fee which will lead to underpriced outbound transaction. We should use a more accurate calculation.

https://github.com/zeta-chain/node/blob/develop/zetaclient/btc_signer.go#L117

ws4charlie self-assigned this

ws4charlie mentioned this issue

fix: skip Goerli BlobTxType transaction and Mumbai empty block #1665

Merged

10 tasks

lumtis mentioned this issue

Closed

lumtis added the zetaclient label

ws4charlie mentioned this issue

fix: fix SegWit tx size estimation (in vByte) and gas fee calculation #1669

Merged

10 tasks

ws4charlie closed this as completed in #1669

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment