Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ZRC20 conversion rate from RateLimiterFlags to a separate structure #2217

Closed
lumtis opened this issue May 20, 2024 · 1 comment
Closed

Comments

@lumtis
Copy link
Member

lumtis commented May 20, 2024

Describe the Issue
The ZRC20 staking feature would require to use a conversion rate for ZRC20s. The first and simplest solution is to set this values from authority messages. Since we already store these values for the rate limiter, we can set these values into a general structure separated from the rate limiter flags. The rate limiter would reuse these values.

Expected Outcome
Remove ConversionRate from RateLimiter
Create a ZRC20ConversionRates structure in the authority module (since used by different unrelated module in the chai, looks the best place for it)

@lumtis
Copy link
Member Author

lumtis commented May 28, 2024

No longer in consideration

@lumtis lumtis closed this as completed May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant