Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate to buf #498

Closed
wants to merge 16 commits into from
Closed

refactor: migrate to buf #498

wants to merge 16 commits into from

Conversation

fadeev
Copy link
Member

@fadeev fadeev commented Apr 6, 2023

  • added buf configuration files in proto/
  • moved proto directories for modules into zetacore, so proto/crosschain/* becomes proto/zetacore/crosschain/*. This is a good practice and makes the source code compatible with tools like Telescope among other things.
  • updated import statements in proto files to match the new directory structure
  • switched to a leading dot syntax (fully-qualified name) to resolve some naming conflicts when importing types from other packages
  • added scripts/protocgen.sh
  • removed third_party/proto as buf handles dependencies.

To compile proto files run ./scripts/protocgen.sh. Currently, without Docker.

@fadeev fadeev marked this pull request as ready for review April 10, 2023 16:32
@brewmaster012
Copy link
Collaborator

hi @fadeev let's get this PR merged soon?

@kingpinXD any pending PRs that might have changed protobuf definitions that may need coordinated PR merge?

I'll be working on a PR that need to change/add protobuf defs, hopefully will be using the new system.

@kingpinXD
Copy link
Contributor

hi @fadeev let's get this PR merged soon?

@kingpinXD any pending PRs that might have changed protobuf definitions that may need coordinated PR merge?

I'll be working on a PR that need to change/add protobuf defs, hopefully will be using the new system.

No , lets go ahead and merge

@fadeev
Copy link
Member Author

fadeev commented Apr 18, 2023

If this is ready for merging, @brewmaster012 @kingpinXD please leave a review. Thanks!

@fadeev
Copy link
Member Author

fadeev commented Apr 21, 2023

Smoke test is still failing. I think the issue might be in the following.

Before

import (
    _ "github.com/gogo/protobuf/gogoproto"
)

After

import (
    _ "github.com/cosmos/gogoproto/gogoproto"
)

@fadeev fadeev marked this pull request as draft April 21, 2023 13:52
@fadeev
Copy link
Member Author

fadeev commented Apr 21, 2023

Superseded by #520

@fadeev fadeev closed this Apr 21, 2023
@lumtis lumtis deleted the feat/buf branch October 27, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants