-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate to buf
#498
Conversation
hi @fadeev let's get this PR merged soon? @kingpinXD any pending PRs that might have changed protobuf definitions that may need coordinated PR merge? I'll be working on a PR that need to change/add protobuf defs, hopefully will be using the new system. |
No , lets go ahead and merge |
If this is ready for merging, @brewmaster012 @kingpinXD please leave a review. Thanks! |
Smoke test is still failing. I think the issue might be in the following. Beforeimport (
_ "github.com/gogo/protobuf/gogoproto"
) Afterimport (
_ "github.com/cosmos/gogoproto/gogoproto"
) |
Superseded by #520 |
buf
configuration files inproto/
zetacore
, soproto/crosschain/*
becomesproto/zetacore/crosschain/*
. This is a good practice and makes the source code compatible with tools like Telescope among other things.scripts/protocgen.sh
third_party/proto
asbuf
handles dependencies.To compile proto files run
./scripts/protocgen.sh
. Currently, without Docker.