We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pytorch-es-tic-tac-toe/envs.py
Line 93 in 05eff94
this method is not a valid assertion for a draw. it returns True when the board is completely filled, regardless if a player wins.
True
the correct check should be something like this:
def isDraw(self): if "-" not in self.board and not self.isWin(): return True else: return False
The text was updated successfully, but these errors were encountered:
No branches or pull requests
pytorch-es-tic-tac-toe/envs.py
Line 93 in 05eff94
this method is not a valid assertion for a draw. it returns
True
when the board is completely filled, regardless if a player wins.the correct check should be something like this:
The text was updated successfully, but these errors were encountered: