Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isdraw method is not valid #1

Open
mynameisvinn opened this issue Dec 26, 2017 · 0 comments
Open

isdraw method is not valid #1

mynameisvinn opened this issue Dec 26, 2017 · 0 comments

Comments

@mynameisvinn
Copy link

mynameisvinn commented Dec 26, 2017

def isDraw(self, board):

this method is not a valid assertion for a draw. it returns True when the board is completely filled, regardless if a player wins.

the correct check should be something like this:

    def isDraw(self):
        if "-" not in self.board and not self.isWin():
            return True
        else:
            return False
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant