Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recovery issue 390 Unicode #394

Closed
hymkor opened this issue Nov 5, 2020 · 8 comments
Closed

Recovery issue 390 Unicode #394

hymkor opened this issue Nov 5, 2020 · 8 comments
Assignees
Labels

Comments

@hymkor
Copy link
Collaborator

hymkor commented Nov 5, 2020

The issue 390 is forbidden. This is recovery issue from notification mail

@.nu8 wrote (Sep. 21,2020)

I see that 2 byte characters are currently supported:

https://en.wikipedia.org/wiki/UTF-8

that is, essentially everything up to U+07FF. Example:

Ç (U+00C7)
You can paste this or enter it with Alt + 128 on Windows, assuming Windows
Terminal is being used. However it seems 3 and 4 byte characters are not
supported. Example:

₧ (U+20A7)
with PowerShell, you can paste the character, or on Windows you can enter as
Alt + 158. However Yori does not accept paste or keyboard input of this
character.

@hymkor hymkor self-assigned this Nov 5, 2020
@hymkor hymkor added the bug label Nov 5, 2020
@hymkor
Copy link
Collaborator Author

hymkor commented Nov 5, 2020

@.nu8 wrote on Sep.22,2020

Its not just that one character. Its many 3 byte characters, for example these
too:

⌂ U+2302
⌐ U+2310
░ U+2591
▒ U+2592
▓ U+2593

@hymkor
Copy link
Collaborator Author

hymkor commented Nov 5, 2020

@.nu8 wrote on Sep.22,2020

Regarding this original posted issue, it has been resolved. However two new
issues exist. First, if you enter echo ! and then HOME, you get this:

$ |echo !

where | is the cursor. However if you enter echo ∞ and then HOME, you get
this:

|$echo ∞

so the cursor moves behind the prompt, and the input is shifted one character
back. I think this is not correct behavior. Second, now that 3 bytes characters
have been resolved, I would point that 4 byte characters have issue. For example
if you try to enter 😀 (U+1F600), you get this:

$ echo ��

��

Let me know if you want me to create new issue for either of these items,
thank you!

@hymkor
Copy link
Collaborator Author

hymkor commented Nov 5, 2020

@.nu8 wrote on Sep.23,2020

On the Windows Terminal: NG. ∞ requires ONE CELL . This view seems to be same as you report.
image
Note that other shells are successful with Windows Terminal. For example
PowerShell:
image
and Nushell:
image
But, on the Windows Terminal, nyagos prints it as is.
image
If � is displayed, it is possible that your terminal has no fonts for the
character.

I get this result with Nyagos and Windows Terminal:
image
Compare with Nushell and Windows Terminal:
image

@hymkor
Copy link
Collaborator Author

hymkor commented Nov 5, 2020

@.nu8 wrote Sep.23,2020

I am entering 😀 using (Window key + ;) or (Window key + .)

@hymkor
Copy link
Collaborator Author

hymkor commented Nov 5, 2020

@nu.8 wrote Sep.23,2020

ok, everything looks good! Thank you!

Maybe I have a new shell now :)

@hymkor
Copy link
Collaborator Author

hymkor commented Nov 5, 2020

@.nu8 wrote Oct.4,2020

Actually, I do notice one more issue. If I enter a composable character such as
https://emojipedia.org/man-farmer with Nushell everything is fine:
image
but if I enter the same character with Nyagos, only the output is correct:
image

@hymkor
Copy link
Collaborator Author

hymkor commented Nov 5, 2020

@.nu8 wrote Oct.5,2020

@ zetamatta for my use, the ZWJ is not needed. But I wanted to raise the problem in case you wanted to address it. For my needs the issue is complete, thank you!

@hymkor
Copy link
Collaborator Author

hymkor commented Dec 14, 2020

ZWJ is supported on 4.4.9_0.

@hymkor hymkor closed this as completed Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant